<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - clEnqueueNDRangeKernel global_work_offset ignored" href="https://bugs.freedesktop.org/show_bug.cgi?id=86326#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - clEnqueueNDRangeKernel global_work_offset ignored" href="https://bugs.freedesktop.org/show_bug.cgi?id=86326">bug 86326</a> from <a class="email" href="mailto:tstellar@gmail.com" title="Tom Stellard <tstellar@gmail.com>"> Tom Stellard</a> <pre>Comment on <a href="attachment.cgi?id=114336" name="attach_114336" title="LLVM AMDGPU get_global_offset() patch">attachment 114336</a> <a href="attachment.cgi?id=114336&action=edit" title="LLVM AMDGPU get_global_offset() patch">[details]</a> <a href='page.cgi?id=splinter.html&bug=86326&attachment=114336'>[review]</a> LLVM AMDGPU get_global_offset() patch Review of <a href="attachment.cgi?id=114336" name="attach_114336" title="LLVM AMDGPU get_global_offset() patch">attachment 114336</a> <a href="attachment.cgi?id=114336&action=edit" title="LLVM AMDGPU get_global_offset() patch">[details]</a> <a href='page.cgi?id=splinter.html&bug=86326&attachment=114336'>[review]</a>: ----------------------------------------------------------------- Hi, Thanks for the patch. After making the changes below, could you send the new patch to <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>? ::: lib/Target/R600/SIInstrInfo.h @@ -371,4 +371,4 @@ > > GLOBAL_SIZE_Z = 20, > > LOCAL_SIZE_X = 24, > > LOCAL_SIZE_Y = 28, > > - LOCAL_SIZE_Z = 32 > > + LOCAL_SIZE_Z = 32, > > + LOCAL_SIZE_Z = 32, This additional comma is unnecessary. We should add another enum here for KernelABIInputOffsets and then add entries for WORK_DIM and GLOBAL_OFFSET_{X,Y,Z}, and use these instead of constants in SIISelLowering.cp</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>