<p dir="ltr"><br>
On Mar 25, 2015 7:43 PM, "Connor Abbott" <<a href="mailto:cwabbott0@gmail.com">cwabbott0@gmail.com</a>> wrote:<br>
><br>
> On Wed, Mar 25, 2015 at 7:21 PM, Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>> wrote:<br>
> > Everything is already in place; we simply have to take the scalar code<br>
> > generation path. This gives us SIMD8 VS programs, instead of SIMD4x2.<br>
> ><br>
> > v2: Rebase on the patch that drops brw->gen >= 8.<br>
> ><br>
> > Signed-off-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>><br>
> > Reviewed-by: Jordan Justen <<a href="mailto:jordan.l.justen@intel.com">jordan.l.justen@intel.com</a>><br>
> > ---<br>
> > src/mesa/drivers/dri/i965/brw_vec4.cpp | 14 ++++++++++----<br>
> > 1 file changed, 10 insertions(+), 4 deletions(-)<br>
> ><br>
> > diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp<br>
> > index 9d2e375..38fb1c3 100644<br>
> > --- a/src/mesa/drivers/dri/i965/brw_vec4.cpp<br>
> > +++ b/src/mesa/drivers/dri/i965/brw_vec4.cpp<br>
> > @@ -1823,7 +1823,7 @@ brw_vs_emit(struct brw_context *brw,<br>
> > if (unlikely(INTEL_DEBUG & DEBUG_VS))<br>
> > brw_dump_ir("vertex", prog, &shader->base, &c->vp->program.Base);<br>
> ><br>
> > - if (prog && brw->scalar_vs) {<br>
> > + if (brw->scalar_vs && (prog || getenv("INTEL_USE_NIR"))) {<br>
><br>
> Aren't we using Jason's fancier thing everywhere else for checking<br>
> INTEL_USE_NIR? That should also let you turn it on by default, which<br>
> seems like a good idea even if it's not on for GLSL yet.</p>
<p dir="ltr">Thanks for catching that. Yes, we should use the "fancier thing"</p>
<p dir="ltr">> > fs_visitor v(brw, mem_ctx, &c->key, prog_data, prog, &c->vp->program, 8);<br>
> > if (!v.run_vs()) {<br>
> > if (prog) {<br>
> > @@ -1841,9 +1841,15 @@ brw_vs_emit(struct brw_context *brw,<br>
> > &c->vp->program.Base, v.promoted_constants,<br>
> > v.runtime_check_aads_emit, "VS");<br>
> > if (INTEL_DEBUG & DEBUG_VS) {<br>
> > - char *name = ralloc_asprintf(mem_ctx, "%s vertex shader %d",<br>
> > - prog->Label ? prog->Label : "unnamed",<br>
> > - prog->Name);<br>
> > + char *name;<br>
> > + if (prog) {<br>
> > + name = ralloc_asprintf(mem_ctx, "%s vertex shader %d",<br>
> > + prog->Label ? prog->Label : "unnamed",<br>
> > + prog->Name);<br>
> > + } else {<br>
> > + name = ralloc_asprintf(mem_ctx, "vertex program %d",<br>
> > + c->vp-><a href="http://program.Base.Id">program.Base.Id</a>);<br>
> > + }<br>
> > g.enable_debug(name);<br>
> > }<br>
> > g.generate_code(v.cfg, 8);<br>
> > --<br>
> > 2.3.4<br>
> ><br>
> > _______________________________________________<br>
> > mesa-dev mailing list<br>
> > <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> > <a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
> _______________________________________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</p>