<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:jfonseca@vmware.com" title="José Fonseca <jfonseca@vmware.com>"> <span class="fn">José Fonseca</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [r600g, bisected] regression: NI/Turks crash on WebGL Water (most WebGL stuff)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=90207">bug 90207</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [r600g, bisected] regression: NI/Turks crash on WebGL Water (most WebGL stuff)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=90207#c17">Comment # 17</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [r600g, bisected] regression: NI/Turks crash on WebGL Water (most WebGL stuff)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=90207">bug 90207</a>
from <span class="vcard"><a class="email" href="mailto:jfonseca@vmware.com" title="José Fonseca <jfonseca@vmware.com>"> <span class="fn">José Fonseca</span></a>
</span></b>
<pre>(In reply to Tapani Pälli from <a href="show_bug.cgi?id=90207#c16">comment #16</a>)
<span class="quote">> Yep it is correct, just like with _mesa_longest_attribute_name_length. </span >
Thanks. I pushed the fix now.
<span class="quote">> Not sure why I did not manage to hit this.</span >
It's random -- I think that is_active_attrib ends up interpreting random
pointer addresses as enums and decide on them. Maybe the randomness is higher
with gallium drivers.
It was only when I try to print var->name that things started to crash
consistently for me.
<span class="quote">> > I think we should invest the time to make RESOURCE_VAR and friends more
> > robust, by adding assertions that the types are indeed correct. (Replace
> > DECL_RESOURCE_FUNC helper macro by manually written code if necessary.)
> >
> > This sort of bugs is hard to find otherwise.
>
> I agree, current way is too fragile. IMO a type template would be best
> solution. Maybe first just adding the assert for the correct type is good
> start.</span >
Yep.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are on the CC list for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>