<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 19, 2015 at 9:35 PM, Jason Ekstrand <span dir="ltr"><<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">On Tue, May 19, 2015 at 7:08 PM, Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu">imirkin@alum.mit.edu</a>> wrote:<br>
> Hi Nanley,<br>
><br>
> I was expecting to see some code dealing with the fact that the block<br>
> sizes are all different. Did I miss it, or is that still on the TODO<br>
> list?<br>
<br>
</span>I think *most* of that code *should* already be there. In theory,<br>
it's all keyed off of the block size provided by formats.csv.<br>
However, given some of the rendering errors we're currently seeing, it<br>
looks like it may need a little patching here and there. :-)<br>
<span class=""><font color="#888888">--Jason<br>
</font></span><div class=""><div class="h5"><br>
> Cheers,<br>
><br>
> -ilia<br>
><br>
> P.S. Congrats on your first public patch submission to mesa-dev :)<br>
><br></div></div></blockquote><div>Thanks for the welcome!</div><div>- Nanley</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class="h5">
> On Tue, May 19, 2015 at 8:48 PM, Nanley Chery <<a href="mailto:nanleychery@gmail.com">nanleychery@gmail.com</a>> wrote:<br>
>> From: Nanley Chery <<a href="mailto:nanley.g.chery@intel.com">nanley.g.chery@intel.com</a>><br>
>><br>
>> This patch series adds support for the KHR_texture_compression_astc_{ldr,hdr}<br>
>> extensions. The last two commits enable support for Skylake systems.<br>
>><br>
>> Some rendering issues were encountered during testing, so there is some more<br>
>> work to be done on this feature. The Piglit tests for this extension can be<br>
>> found here: <a href="http://cgit.freedesktop.org/~nchery/piglit" target="_blank">cgit.freedesktop.org/~nchery/piglit</a><br>
>><br>
>> Nanley Chery (10):<br>
>> mesa/formats: define the 2D ASTC formats<br>
>> glapi: add support for KHR_texture_compression_astc_ldr<br>
>> mesa: disable online compression for ASTC formats<br>
>> mesa: add ASTC extensions to the extensions table<br>
>> mesa/glformats: recognize ASTC formats as compressed<br>
>> mesa/texcompress: enable translation between MESA and GL ASTC formats<br>
>> mesa/teximage: return the base internal format of the ASTC formats<br>
>> mesa/formats: store whether or not a format is sRGB in gl_format_info<br>
>> i965/surface_formats: add support for 2D ASTC surface formats<br>
>> i965: enable ASTC support for Skylake<br>
>><br>
>> .../glapi/gen/KHR_texture_compression_astc.xml | 40 ++++++<br>
>> src/mapi/glapi/gen/Makefile.am | 1 +<br>
>> src/mapi/glapi/gen/gl_API.xml | 2 +-<br>
>> src/mesa/drivers/dri/i965/brw_defines.h | 36 +++++<br>
>> src/mesa/drivers/dri/i965/brw_surface_formats.c | 67 ++++++++-<br>
>> src/mesa/drivers/dri/i965/intel_extensions.c | 6 +<br>
>> src/mesa/main/extensions.c | 3 +<br>
>> src/mesa/main/format_info.py | 5 +<br>
>> src/mesa/main/formats.c | 159 +++++++++++++++++----<br>
>> src/mesa/main/formats.csv | 31 ++++<br>
>> src/mesa/main/formats.h | 30 ++++<br>
>> src/mesa/main/glformats.c | 29 ++++<br>
>> src/mesa/main/mtypes.h | 3 +<br>
>> src/mesa/main/texcompress.c | 136 ++++++++++++++++++<br>
>> src/mesa/main/teximage.c | 64 +++++++++<br>
>> src/mesa/swrast/s_texfetch.c | 32 ++++-<br>
>> 16 files changed, 616 insertions(+), 28 deletions(-)<br>
>> create mode 100644 src/mapi/glapi/gen/KHR_texture_compression_astc.xml<br>
>><br>
>> --<br>
>> 2.4.1<br>
>><br>
>> _______________________________________________<br>
>> mesa-dev mailing list<br>
>> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
>> <a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
> _______________________________________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</div></div></blockquote></div><br></div></div>