<div dir="ltr">Hi Ilia,<div><br></div><div>Thanks for finding these errors. I'll have fixes in v2.</div><div><br></div><div>- Nanley<br></div><div><br></div><div><div class="gmail_extra"><div class="gmail_quote">On Tue, May 19, 2015 at 7:07 PM, Ilia Mirkin <span dir="ltr"><<a href="mailto:imirkin@alum.mit.edu" target="_blank">imirkin@alum.mit.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On Tue, May 19, 2015 at 8:48 PM, Nanley Chery <<a href="mailto:nanleychery@gmail.com" target="_blank">nanleychery@gmail.com</a>> wrote:<br> > From: Nanley Chery <<a href="mailto:nanley.g.chery@intel.com" target="_blank">nanley.g.chery@intel.com</a>><br> ><br> > Signed-off-by: Nanley Chery <<a href="mailto:nanley.g.chery@intel.com" target="_blank">nanley.g.chery@intel.com</a>><br> > ---<br> > .../glapi/gen/KHR_texture_compression_astc.xml | 40 ++++++++++++++++++++++<br> > src/mapi/glapi/gen/Makefile.am | 1 +<br> > src/mapi/glapi/gen/gl_API.xml | 2 +-<br> > 3 files changed, 42 insertions(+), 1 deletion(-)<br> > create mode 100644 src/mapi/glapi/gen/KHR_texture_compression_astc.xml<br> ><br> > diff --git a/src/mapi/glapi/gen/KHR_texture_compression_astc.xml b/src/mapi/glapi/gen/KHR_texture_compression_astc.xml<br> > new file mode 100644<br> > index 0000000..68dbf19<br> > --- /dev/null<br> > +++ b/src/mapi/glapi/gen/KHR_texture_compression_astc.xml<br> > @@ -0,0 +1,40 @@<br> > +<?xml version="1.0"?><br> > +<!DOCTYPE OpenGLAPI SYSTEM "gl_API.dtd"><br> > +<br> > +<OpenGLAPI><br> > +<br> > +<category name="GL_KHR_texture_compression_astc_ldr" number="118"><br> > +<br> > + <enum name="COMPRESSED_RGBA_ASTC_4x4_KHR" value = "0x93B0"/><br> <br> </span>I think we use value= everywhere, not value =. Minor point though.<br> <span><br> > + <enum name="COMPRESSED_RGBA_ASTC_5x4_KHR" value = "0x93B1"/><br> > + <enum name="COMPRESSED_RGBA_ASTC_5x5_KHR" value = "0x93B2"/><br> > + <enum name="COMPRESSED_RGBA_ASTC_6x5_KHR" value = "0x93B3"/><br> > + <enum name="COMPRESSED_RGBA_ASTC_6x6_KHR" value = "0x93B4"/><br> > + <enum name="COMPRESSED_RGBA_ASTC_8x5_KHR" value = "0x93B5"/><br> > + <enum name="COMPRESSED_RGBA_ASTC_8x6_KHR" value = "0x93B6"/><br> > + <enum name="COMPRESSED_RGBA_ASTC_8x8_KHR" value = "0x93B7"/><br> > + <enum name="COMPRESSED_RGBA_ASTC_10x5_KHR" value = "0x93B8"/><br> > + <enum name="COMPRESSED_RGBA_ASTC_10x6_KHR" value = "0x93B9"/><br> > + <enum name="COMPRESSED_RGBA_ASTC_10x8_KHR" value = "0x93BA"/><br> > + <enum name="COMPRESSED_RGBA_ASTC_10x10_KHR" value = "0x93BB"/><br> > + <enum name="COMPRESSED_RGBA_ASTC_12x10_KHR" value = "0x93BC"/><br> > + <enum name="COMPRESSED_RGBA_ASTC_12x12_KHR" value = "0x93BD"/><br> > +<br> > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_4x4_KHR" value = "0x93D0"/><br> <br> </span>The spec I'm looking at calls it "COMPRESSED_SRGB8_ALPHA8_ASTC_4x4_KHR".<br> <div><div><br> > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_5x4_KHR" value = "0x93D1"/><br> > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_5x5_KHR" value = "0x93D2"/><br> > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_6x5_KHR" value = "0x93D3"/><br> > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_6x6_KHR" value = "0x93D4"/><br> > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_8x5_KHR" value = "0x93D5"/><br> > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_8x6_KHR" value = "0x93D6"/><br> > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_8x8_KHR" value = "0x93D7"/><br> > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_10x5_KHR" value = "0x93D8"/><br> > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_10x6_KHR" value = "0x93D9"/><br> > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_10x8_KHR" value = "0x93DA"/><br> > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_10x10_KHR" value = "0x93DB"/><br> > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_12x10_KHR" value = "0x93DC"/><br> > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_12x12_KHR" value = "0x93DD"/><br> > +<br> > +</category><br> > +<br> > +</OpenGLAPI><br> > diff --git a/src/mapi/glapi/gen/Makefile.am b/src/mapi/glapi/gen/Makefile.am<br> > index adebd5c..e0c09ec 100644<br> > --- a/src/mapi/glapi/gen/Makefile.am<br> > +++ b/src/mapi/glapi/gen/Makefile.am<br> > @@ -185,6 +185,7 @@ API_XML = \<br> > INTEL_performance_query.xml \<br> > KHR_debug.xml \<br> > KHR_context_flush_control.xml \<br> > + KHR_texture_compression_astc.xml \<br> > NV_conditional_render.xml \<br> > NV_primitive_restart.xml \<br> > NV_texture_barrier.xml \<br> > diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml<br> > index 3090b9f..38309a4 100644<br> > --- a/src/mapi/glapi/gen/gl_API.xml<br> > +++ b/src/mapi/glapi/gen/gl_API.xml<br> > @@ -8162,7 +8162,7 @@<br> ><br> > <xi:include href="ARB_texture_storage.xml" xmlns:xi="<a href="http://www.w3.org/2001/XInclude" target="_blank">http://www.w3.org/2001/XInclude</a>"/><br> ><br> > -<br> > +<xi:include href="KHR_texture_compression_astc.xml" xmlns:xi="<a href="http://www.w3.org/2001/XInclude" target="_blank">http://www.w3.org/2001/XInclude</a>"/><br> ><br> > <xi:include href="KHR_debug.xml" xmlns:xi="<a href="http://www.w3.org/2001/XInclude" target="_blank">http://www.w3.org/2001/XInclude</a>"/><br> ><br> > --<br> > 2.4.1<br> ><br> </div></div>> _______________________________________________<br> > mesa-dev mailing list<br> > <a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br> > <a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br> </blockquote></div><br></div></div></div>