Just disable the bs warnings. When we're drowning, I might reevaluate my stance. <div class="gmail_quote">On Jun 5, 2015 11:39 PM, "Tobias Klausmann" <<a href="mailto:tobias.johannes.klausmann@mni.thm.de">tobias.johannes.klausmann@mni.thm.de</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Mh especially GCC 5 seems to be picky about code, if we don't work around we soon will only see warnings for every file. Even if the compiler is buggy/to picky we should fix the code to not drown in warnings... :-) On 05.06.2015 22:23, Ilia Mirkin wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Sure. Fix it in GCC :) disable the bogus warning, whatever. I really really hate pandering to broken tools, sending the message that it's ok for the tools to be broken. On Jun 5, 2015 5:20 PM, "Martin Peres" <<a href="mailto:martin.peres@linux.intel.com" target="_blank">martin.peres@linux.intel.com</a> <mailto:<a href="mailto:martin.peres@linux.intel.com" target="_blank">martin.peres@linux.intel.com</a>>> wrote: On 05/06/15 17:12, Ilia Mirkin wrote: But if codegen fails, the code is never displayed as I recall. Again, this I'd going from memory... Good memory. It looks ugly though. In general, I would still want to fix the warning because I hate needing to revert my patches to check if I introduced warnings or not. In this particular case it is probably OK because no-one will likely touch this file for the foreseeable future :) _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote> </blockquote></div>