<p dir="ltr">LGTM</p>
<p dir="ltr">Reviewed-by: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com">jason.ekstrand@intel.com</a>></p>
<div class="gmail_quote">On Jun 10, 2015 7:39 AM, "Francisco Jerez" <<a href="mailto:currojerez@riseup.net">currojerez@riseup.net</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Instead use fs_builder::null_reg_f() which has the correct register<br>
width. Avoids the assertion failure in fs_builder::emit() hit by the<br>
"ES3-CTS.shaders.loops.for_dynamic_iterations.unconditional_break_fragment"<br>
GLES3 conformance test introduced by 4af4cfba9ee1014baa4a777660fc9d53d57e4c82.<br>
<br>
Reported-and-reviewed-by: Tapani Pälli <<a href="mailto:tapani.palli@intel.com">tapani.palli@intel.com</a>><br>
---<br>
src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp<br>
index 7789ca7..5563c5a 100644<br>
--- a/src/mesa/drivers/dri/i965/brw_fs.cpp<br>
+++ b/src/mesa/drivers/dri/i965/brw_fs.cpp<br>
@@ -3234,7 +3234,7 @@ fs_visitor::lower_integer_multiplication()<br>
ibld.ADD(dst, low, high);<br>
<br>
if (inst->conditional_mod) {<br>
- fs_reg null(retype(brw_null_reg(), inst->dst.type));<br>
+ fs_reg null(retype(ibld.null_reg_f(), inst->dst.type));<br>
set_condmod(inst->conditional_mod,<br>
ibld.MOV(null, inst->dst));<br>
}<br>
--<br>
2.3.5<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div>