<div dir="ltr">Wonderful Marek. Many thanks to you all. I hope till the end of the year we will have OGL 4.3 in Mesa.</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 17, 2015 at 2:18 AM, Marek Olšák <span dir="ltr"><<a href="mailto:maraeo@gmail.com" target="_blank">maraeo@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">You can also use this for nicer reviewing:<br>
<a href="http://cgit.freedesktop.org/~mareko/mesa/log/?h=tessellation-review" rel="noreferrer" target="_blank">http://cgit.freedesktop.org/~mareko/mesa/log/?h=tessellation-review</a><br>
<br>
Please note that there are differences from Chris Forbes's<br>
tessellation branches. I think I modified almost all patches when I<br>
was reviewing them, fixing them, and cleaning them up.<br>
<span class="HOEnZb"><font color="#888888"><br>
Marek<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
On Wed, Jun 17, 2015 at 1:00 AM, Marek Olšák <<a href="mailto:maraeo@gmail.com">maraeo@gmail.com</a>> wrote:<br>
> Hi,<br>
><br>
> First, I'd like to thank Fabian Bieler, Chris Forbes, and Ilia Mirkin<br>
> for their contributions to this.<br>
><br>
> The development of tessellation has reached the point that the only<br>
> way to make it better and more compliant is to write piglit tests that<br>
> help find small bugs that are difficult to catch during code review.<br>
> According to piglit, it's already more compliant than the NVIDIA<br>
> driver. (The NVIDIA GLSL compiler sometimes even dies with an internal<br>
> error on some of the variable indexing tests. I haven't tested<br>
> Catalyst.)<br>
><br>
> Other than piglit, the following apps have been tested:<br>
> - Unigine Heaven 4.0 (wireframe both on and off)<br>
> - TessMark 0.3.0 *<br>
> - GpuTest 0.7.0 containing a newer version of TessMark *<br>
> - Tutorials 30 and 31 from <a href="http://ogldev.atspace.co.uk/" rel="noreferrer" target="_blank">http://ogldev.atspace.co.uk/</a> *<br>
><br>
> (* These don't work with the OpenGL Core profile and need overrides<br>
> and code hacks to enable OpenGL 4.0 Compatibility)<br>
><br>
> The RadeonSI driver support is complete and requires LLVM 3.6.2. There<br>
> is just one small bug with GpuTest 0.7.0.<br>
><br>
> The patches will be split up into 3 series:<br>
> 1) Mesa + GLSL<br>
> 2) State tracker<br>
> 3) Radeonsi<br>
><br>
>  docs/GL3.txt                                      |   2 +-<br>
>  docs/relnotes/10.7.0.html                         |   1 +<br>
>  src/gallium/docs/source/screen.rst                |   4 +<br>
>  src/gallium/drivers/freedreno/freedreno_screen.c  |   1 +<br>
>  src/gallium/drivers/i915/i915_screen.c            |   1 +<br>
>  src/gallium/drivers/ilo/ilo_screen.c              |   1 +<br>
>  src/gallium/drivers/llvmpipe/lp_screen.c          |   1 +<br>
>  src/gallium/drivers/nouveau/nv30/nv30_screen.c    |   1 +<br>
>  src/gallium/drivers/nouveau/nv50/nv50_screen.c    |   1 +<br>
>  src/gallium/drivers/nouveau/nvc0/nvc0_screen.c    |   1 +<br>
>  src/gallium/drivers/r300/r300_screen.c            |   1 +<br>
>  src/gallium/drivers/r600/r600_pipe.c              |   1 +<br>
>  src/gallium/drivers/radeon/r600_pipe_common.c     |   6 +<br>
>  src/gallium/drivers/radeon/r600_pipe_common.h     |  20 +-<br>
>  src/gallium/drivers/radeon/radeon_llvm.h          |  14 +-<br>
>  src/gallium/drivers/radeon/radeon_llvm_emit.c     |   2 +<br>
>  .../drivers/radeon/radeon_setup_tgsi_llvm.c       |  40 +-<br>
>  src/gallium/drivers/radeonsi/si_blit.c            |   2 +<br>
>  src/gallium/drivers/radeonsi/si_descriptors.c     | 251 ++++--<br>
>  src/gallium/drivers/radeonsi/si_hw_context.c      |   8 +<br>
>  src/gallium/drivers/radeonsi/si_pipe.c            |  22 +-<br>
>  src/gallium/drivers/radeonsi/si_pipe.h            |  29 +-<br>
>  src/gallium/drivers/radeonsi/si_shader.c          | 835 ++++++++++++++++++--<br>
>  src/gallium/drivers/radeonsi/si_shader.h          | 123 ++-<br>
>  src/gallium/drivers/radeonsi/si_state.c           |  47 +-<br>
>  src/gallium/drivers/radeonsi/si_state.h           |  23 +-<br>
>  src/gallium/drivers/radeonsi/si_state_draw.c      | 217 ++++-<br>
>  src/gallium/drivers/radeonsi/si_state_shaders.c   | 494 +++++++++++-<br>
>  src/gallium/drivers/softpipe/sp_screen.c          |   1 +<br>
>  src/gallium/drivers/svga/svga_screen.c            |   1 +<br>
>  src/gallium/drivers/vc4/vc4_screen.c              |   1 +<br>
>  src/gallium/include/pipe/p_defines.h              |   1 +<br>
>  src/glsl/Makefile.sources                         |   1 +<br>
>  src/glsl/ast.h                                    |  55 +-<br>
>  src/glsl/ast_array_index.cpp                      |  47 +-<br>
>  src/glsl/ast_to_hir.cpp                           | 350 +++++++-<br>
>  src/glsl/ast_type.cpp                             | 115 ++-<br>
>  src/glsl/builtin_functions.cpp                    |   4 +-<br>
>  src/glsl/builtin_variables.cpp                    | 112 ++-<br>
>  src/glsl/glcpp/glcpp-parse.y                      |   3 +<br>
>  src/glsl/glsl_lexer.ll                            |   5 +-<br>
>  src/glsl/glsl_parser.yy                           | 133 +++-<br>
>  src/glsl/glsl_parser_extras.cpp                   |  60 +-<br>
>  src/glsl/glsl_parser_extras.h                     |  48 +-<br>
>  src/glsl/glsl_types.cpp                           |   5 +<br>
>  src/glsl/glsl_types.h                             |   6 +<br>
>  src/glsl/ir.cpp                                   |   2 +<br>
>  src/glsl/ir.h                                     |   1 +<br>
>  src/glsl/ir_optimization.h                        |   8 +-<br>
>  src/glsl/ir_print_visitor.cpp                     |   5 +-<br>
>  src/glsl/ir_reader.cpp                            |   2 +<br>
>  src/glsl/ir_set_program_inouts.cpp                |  96 ++-<br>
>  src/glsl/link_interface_blocks.cpp                |  11 +-<br>
>  src/glsl/link_varyings.cpp                        | 183 ++++-<br>
>  src/glsl/link_varyings.h                          |  16 +-<br>
>  src/glsl/linker.cpp                               | 415 +++++++++-<br>
>  src/glsl/lower_clip_distance.cpp                  | 185 +++--<br>
>  src/glsl/lower_named_interface_blocks.cpp         |   8 +-<br>
>  src/glsl/lower_output_reads.cpp                   |  13 +-<br>
>  src/glsl/lower_packed_varyings.cpp                |   1 +<br>
>  src/glsl/lower_tess_level.cpp                     | 462 +++++++++++<br>
>  src/glsl/lower_variable_index_to_cond_assign.cpp  |  43 +-<br>
>  src/glsl/main.cpp                                 |   8 +-<br>
>  src/glsl/shader_enums.h                           |  21 +-<br>
>  src/glsl/standalone_scaffolding.cpp               |   1 +<br>
>  src/glsl/standalone_scaffolding.h                 |   4 +<br>
>  src/glsl/test_optpass.cpp                         |   3 +-<br>
>  src/mapi/glapi/gen/ARB_tessellation_shader.xml    |  62 ++<br>
>  src/mapi/glapi/gen/gl_API.xml                     |   6 +-<br>
>  src/mapi/glapi/gen/gl_enums.py                    |   1 +<br>
>  src/mesa/Makefile.sources                         |   1 +<br>
>  src/mesa/drivers/common/meta.c                    |   2 +<br>
>  src/mesa/drivers/dri/common/drirc                 |  23 +-<br>
>  src/mesa/drivers/dri/i965/brw_context.c           |   1 +<br>
>  src/mesa/drivers/dri/i965/brw_shader.cpp          |  10 +-<br>
>  src/mesa/drivers/dri/i965/intel_debug.c           |   4 +-<br>
>  src/mesa/main/api_validate.c                      |  86 +-<br>
>  src/mesa/main/config.h                            |   8 +<br>
>  src/mesa/main/context.c                           |  12 +<br>
>  src/mesa/main/context.h                           |  11 +<br>
>  src/mesa/main/get.c                               |   1 +<br>
>  src/mesa/main/get_hash_params.py                  |  28 +<br>
>  src/mesa/main/mtypes.h                            | 141 +++-<br>
>  src/mesa/main/pipelineobj.c                       |  32 +-<br>
>  src/mesa/main/queryobj.c                          |   2 +-<br>
>  src/mesa/main/shader_query.cpp                    |  18 +-<br>
>  src/mesa/main/shaderapi.c                         | 182 ++++-<br>
>  src/mesa/main/shaderapi.h                         |   8 +<br>
>  src/mesa/main/shaderobj.h                         |   4 +<br>
>  src/mesa/main/state.c                             |  54 +-<br>
>  src/mesa/main/tests/dispatch_sanity.cpp           |   2 +<br>
>  src/mesa/main/uniforms.c                          |  21 +-<br>
>  src/mesa/program/ir_to_mesa.cpp                   |   2 +-<br>
>  src/mesa/program/prog_print.c                     |  10 +<br>
>  src/mesa/program/program.c                        |  59 ++<br>
>  src/mesa/program/program.h                        |  80 +-<br>
>  src/mesa/state_tracker/st_atom.c                  |   9 +<br>
>  src/mesa/state_tracker/st_atom.h                  |   9 +<br>
>  src/mesa/state_tracker/st_atom_constbuf.c         |  88 ++-<br>
>  src/mesa/state_tracker/st_atom_sampler.c          |  16 +<br>
>  src/mesa/state_tracker/st_atom_shader.c           |  72 ++<br>
>  src/mesa/state_tracker/st_atom_tess.c             |  59 ++<br>
>  src/mesa/state_tracker/st_atom_texture.c          |  52 ++<br>
>  src/mesa/state_tracker/st_cb_program.c            |  58 ++<br>
>  src/mesa/state_tracker/st_context.c               |   3 +<br>
>  src/mesa/state_tracker/st_context.h               |   8 +-<br>
>  src/mesa/state_tracker/st_draw.c                  |   2 +<br>
>  src/mesa/state_tracker/st_extensions.c            |  21 +<br>
>  src/mesa/state_tracker/st_glsl_to_tgsi.cpp        | 159 +++-<br>
>  src/mesa/state_tracker/st_program.c               | 495 ++++++++++--<br>
>  src/mesa/state_tracker/st_program.h               | 122 ++-<br>
>  111 files changed, 5956 insertions(+), 673 deletions(-)<br>
>  create mode 100644 src/glsl/lower_tess_level.cpp<br>
>  create mode 100644 src/mapi/glapi/gen/ARB_tessellation_shader.xml<br>
>  create mode 100644 src/mesa/state_tracker/st_atom_tess.c<br>
><br>
> Marek<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</div></div></blockquote></div><br></div>