<div dir="ltr">Sorry for removing the XXX line. Original message is here: <a href="https://bugs.freedesktop.org/attachment.cgi?id=115539">https://bugs.freedesktop.org/attachment.cgi?id=115539</a><div><br></div><div>At the time <span style="color:rgb(0,0,0);white-space:pre-wrap">src/glx/apple/apple_glapi.c has been developed this patch was not needed I guess so I wonder which change made the regression.</span></div><div><span style="color:rgb(0,0,0);white-space:pre-wrap"><br></span></div><div><span style="color:rgb(0,0,0);white-space:pre-wrap">Cheers</span></div><div><span style="color:rgb(0,0,0);white-space:pre-wrap">Julien</span></div><div class="gmail_extra"><br><div class="gmail_quote">On 18 June 2015 at 19:23, Emil Velikov <span dir="ltr"><<a href="mailto:emil.l.velikov@gmail.com" target="_blank">emil.l.velikov@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 18 June 2015 at 06:53, Julien Isorce <<a href="mailto:julien.isorce@gmail.com">julien.isorce@gmail.com</a>> wrote:<br>
> From: Jon TURNEY <<a href="mailto:jon.turney@dronecode.org.uk">jon.turney@dronecode.org.uk</a>><br>
><br>
> _SET_DrawBuffers requires driDispatchRemapTable,<br>
> so we need to link with libmesa for remap.c.<br>
> libmesa requires the C++ linker.<br>
><br>
> Also need to arrange to call _mesa_init_remap_table()<br>
> to initialize the remap table.<br>
><br>
> Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=90311" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=90311</a><br>
> Signed-off-by: Jon TURNEY <<a href="mailto:jon.turney@dronecode.org.uk">jon.turney@dronecode.org.uk</a>><br>
> ---<br>
> src/glx/Makefile.am     | 5 ++++-<br>
>Â src/glx/apple/apple_glapi.c | 3 +++<br>
>Â 2 files changed, 7 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/src/glx/Makefile.am b/src/glx/Makefile.am<br>
> index 6e50e09..de24496 100644<br>
> --- a/src/glx/Makefile.am<br>
> +++ b/src/glx/Makefile.am<br>
> @@ -139,7 +139,10 @@ libglx_la_SOURCES += \<br>
>Â Â Â Â Â applegl_glx.c<br>
><br>
>Â SUBDIRS += apple<br>
> -libglx_la_LIBADD += $(builddir)/apple/<a href="http://libappleglx.la" rel="noreferrer" target="_blank">libappleglx.la</a><br>
> +libglx_la_LIBADD += \<br>
> +Â Â Â Â $(builddir)/apple/<a href="http://libappleglx.la" rel="noreferrer" target="_blank">libappleglx.la</a> \<br>
> +Â Â Â Â $(top_builddir)/src/mesa/<a href="http://libmesa.la" rel="noreferrer" target="_blank">libmesa.la</a><br>
> +nodist_EXTRA_lib@GL_LIB@_la_SOURCES = dummy.cpp<br>
</div></div>Pulling hunks of mesa into libGL does not sounds like a reasonable<br>
thing. There is a reason why Jon had that XXX: in the original commit<br>
message.<br>
<br>
Cheers,<br>
Emil<br>
</blockquote></div><br></div></div>