<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - glx: make check fails to build on osx" href="https://bugs.freedesktop.org/show_bug.cgi?id=91106#c3">Comment # 3</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - glx: make check fails to build on osx" href="https://bugs.freedesktop.org/show_bug.cgi?id=91106">bug 91106</a> from <a class="email" href="mailto:jon.turney@dronecode.org.uk" title="Jon TURNEY <jon.turney@dronecode.org.uk>"> Jon TURNEY</a> <pre>(In reply to Emil Velikov from <a href="show_bug.cgi?id=91106#c1">comment #1</a>) > +#if defined(GLX_USE_APPLEGL) > +#define _ATTRIBUTE_WEAK __attribute__((weak)) > +#else > +#define _ATTRIBUTE_WEAK > +#endif > + > (If we end up keeping this) Can we avoid redefining it X times ? Ian (the > original author of these tests) should know the details as to why/how we > don't end up with duplicated/conflicting symbols. These really are duplicates that the test harness provides to override the real versions. Unfortunately, ld on OSX doesn't behave that way, and the option -multiply_defined suppress seems to be obsolete. I'm not very keen on scattering __attribute__(weak) around to fix this, but I guess the only other approach is to split those symbols out into a separate object, which is linked with to produce libglx.a, but not into a convenience library which is used by the tests. > + $(top_builddir)/src/mapi/glapi/libglapi.la \ > Which symbols are missing if we omit this ? Noone else seems to need it. glapi_create_table_from_handle, which only exists on APPLE, if memory serves. But linking with glapi and shared-glapi doesn't seem right, so I think this is a sign that something else is wrong.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>