<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:vlee@freedesktop.org" title="Vinson Lee <vlee@freedesktop.org>"> <span class="fn">Vinson Lee</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - SIGSEGV glcpp/glcpp-parse.y:1077"
href="https://bugs.freedesktop.org/show_bug.cgi?id=91290">bug 91290</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Keywords</td>
<td>
</td>
<td>regression
</td>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>anuj.phogat@gmail.com, cworth@cworth.org
</td>
</tr>
<tr>
<td style="text-align:right;">Version</td>
<td>git
</td>
<td>10.3
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - SIGSEGV glcpp/glcpp-parse.y:1077"
href="https://bugs.freedesktop.org/show_bug.cgi?id=91290#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - SIGSEGV glcpp/glcpp-parse.y:1077"
href="https://bugs.freedesktop.org/show_bug.cgi?id=91290">bug 91290</a>
from <span class="vcard"><a class="email" href="mailto:vlee@freedesktop.org" title="Vinson Lee <vlee@freedesktop.org>"> <span class="fn">Vinson Lee</span></a>
</span></b>
<pre>a6e9cd14cad555520ad98213adf541a7687a7498 is the first bad commit
commit a6e9cd14cad555520ad98213adf541a7687a7498
Author: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>>
Date: Fri Jun 6 16:56:59 2014 -0700
glsl/glcpp: Fix preprocessor error condition for macro redefinition
This patch specifically fixes redefinition condition for white space
changes. #define and #undef functionality in GLSL follows the standard
for C++ preprocessors for macro definitions.
From
<a href="https://gcc.gnu.org/onlinedocs/cpp/Undefining-and-Redefining-Macros.html">https://gcc.gnu.org/onlinedocs/cpp/Undefining-and-Redefining-Macros.html</a>:
These definitions are effectively the same:
#define FOUR (2 + 2)
#define FOUR (2 + 2)
#define FOUR (2 /* two */ + 2)
but these are not:
#define FOUR (2 + 2)
#define FOUR ( 2+2 )
#define FOUR (2 * 2)
#define FOUR(score,and,seven,years,ago) (2 + 2)
Fixes Khronos GLES3 CTS tests;
invalid_object_whitespace_vertex
invalid_object_whitespace_fragment
Signed-off-by: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>>
Reviewed-by: Carl Worth <<a href="mailto:cworth@cworth.org">cworth@cworth.org</a>>
:040000 040000 21e3582eed6555a0e4510982863892e0ead45930
6bb0f8508d19b41b5938b9f812b793ba90c278a0 M src
bisect run success</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>