<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Mesa's demo / tools won't compile since EGL changes" href="https://bugs.freedesktop.org/show_bug.cgi?id=91020#c5">Comment # 5</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Mesa's demo / tools won't compile since EGL changes" href="https://bugs.freedesktop.org/show_bug.cgi?id=91020">bug 91020</a> from <a class="email" href="mailto:emil.l.velikov@gmail.com" title="Emil Velikov <emil.l.velikov@gmail.com>"> Emil Velikov</a> <pre>(In reply to George Diamantopoulos from <a href="show_bug.cgi?id=91020#c4">comment #4</a>) > Created <a href="attachment.cgi?id=117106" name="attach_117106" title="Fix build against EGL implementations that don't support the EGL_MESA_screen_surface extension">attachment 117106</a> <a href="attachment.cgi?id=117106&action=edit" title="Fix build against EGL implementations that don't support the EGL_MESA_screen_surface extension">[details]</a> <a href='page.cgi?id=splinter.html&bug=91020&attachment=117106'>[review]</a> [review] > Fix build against EGL implementations that don't support the > EGL_MESA_screen_surface extension > > There is a patch by Frank Binns (posted on mesa-dev) since 2012 on this... > It worked for me, so I'm attaching it here While this should work and has been the approach used so far in mesa-demos, I'm having second doubts how wise of an idea it is. In this particular example, this will result in a "empty" demo/program which won't do anything when run on a EGL_MESA_screen_surface capable driver. I.e. even if your system is perfectly fine, the binary build by your distro/elsewhere with the missing definition will be useless. May I suggest that we add the relevant defines, after including the *GL headers. This way the binary will work on compatible systems, and (should) bail out if the extension is not supported. One could also fix the other similar cases, while at it ;-) Git grep shows some ~120 lines :-P</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>