<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:jfonseca@vmware.com" title="Jose Fonseca <jfonseca@vmware.com>"> <span class="fn">Jose Fonseca</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - rounding.h:102:2: error: #error "Unsupported or undefined LONG_BIT""
href="https://bugs.freedesktop.org/show_bug.cgi?id=91591">bug 91591</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Assignee</td>
<td>mesa-dev@lists.freedesktop.org
</td>
<td>mattst88@gmail.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - rounding.h:102:2: error: #error "Unsupported or undefined LONG_BIT""
href="https://bugs.freedesktop.org/show_bug.cgi?id=91591#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - rounding.h:102:2: error: #error "Unsupported or undefined LONG_BIT""
href="https://bugs.freedesktop.org/show_bug.cgi?id=91591">bug 91591</a>
from <span class="vcard"><a class="email" href="mailto:jfonseca@vmware.com" title="Jose Fonseca <jfonseca@vmware.com>"> <span class="fn">Jose Fonseca</span></a>
</span></b>
<pre>My change only makes an existing bug surface.
Even without my change I believe the warning
rounding.h:107:1: warning: no return statement in function returning non-void
[-Wreturn-type]
was probably there, ever since Matt's commit
<a href="http://cgit.freedesktop.org/mesa/mesa/commit/?id=680de24545d23d0c2b699020267ca484f81a04a9">http://cgit.freedesktop.org/mesa/mesa/commit/?id=680de24545d23d0c2b699020267ca484f81a04a9</a>
. But because it was not fatal, it was easy to miss.
As I said to Matt on mesa-dev ML, it sounds like LONG_BIT is not standard.
MinGW/MSVC at least don't define it. It looks like not all Linux define it
neither.
There was a discussion about on Stack Overflow, but is not very conclusive.
On my system, LONG_BIT is defined in
/usr/include/x86_64-linux-gnu/bits/xopen_lim.h
And /usr/include/limits.h includes it, but not unconditionally:
#ifdef __USE_XOPEN
# include <bits/xopen_lim.h>
#endif</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>