<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 11, 2015 at 4:16 PM, Ilia Mirkin <span dir="ltr"><<a href="mailto:imirkin@alum.mit.edu" target="_blank">imirkin@alum.mit.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Tue, Aug 11, 2015 at 7:07 PM, Nanley Chery <<a href="mailto:nanleychery@gmail.com">nanleychery@gmail.com</a>> wrote:<br>
> From: Nanley Chery <<a href="mailto:nanley.g.chery@intel.com">nanley.g.chery@intel.com</a>><br>
><br>
> Add the classes of compressed formats as layouts. This will make determining if<br>
> a texture is an ASTC format simpler.<br>
><br>
> Cc: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com">jason.ekstrand@intel.com</a>><br>
> Signed-off-by: Nanley Chery <<a href="mailto:nanley.g.chery@intel.com">nanley.g.chery@intel.com</a>><br>
> ---<br>
>Â src/mesa/main/format_info.py |Â 4 +++-<br>
> src/mesa/main/formats.c   | 6 ++++++<br>
> src/mesa/main/formats.h   | 6 ++++++<br>
> src/mesa/main/texcompress.c | 30 ++++++------------------------<br>
>Â 4 files changed, 21 insertions(+), 25 deletions(-)<br>
><br>
> diff --git a/src/mesa/main/format_info.py b/src/mesa/main/format_info.py<br>
> index 3bae57e..b9f12f3 100644<br>
> --- a/src/mesa/main/format_info.py<br>
> +++ b/src/mesa/main/format_info.py<br>
> @@ -103,8 +103,10 @@ def get_mesa_layout(fmat):<br>
>Â Â Â Â return 'MESA_FORMAT_LAYOUT_ARRAY'<br>
>Â Â Â elif fmat.layout == 'packed':<br>
>Â Â Â Â return 'MESA_FORMAT_LAYOUT_PACKED'<br>
> -Â Â else:<br>
> +Â Â elif fmat.layout == 'other':<br>
>Â Â Â Â return 'MESA_FORMAT_LAYOUT_OTHER'<br>
> +Â Â else:<br>
> +Â Â Â return 'MESA_FORMAT_LAYOUT_' + fmat.layout.upper()<br>
<br>
</div></div>This should cover basically every format layout, right? i.e. why not<br>
just make this function be<br>
<br>
return 'MESA_FORMAT_LAYOUT_' + fmat.layout.upper() ?<br>
</blockquote></div><br></div><div class="gmail_extra">Good idea.</div><div class="gmail_extra"><br></div><div class="gmail_extra">Thanks,</div><div class="gmail_extra">Nanley</div></div>