<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">This patch is the result of several
discussions on our irc channels.<br>
<br>
I amended the commit message to:<br>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<p class="commit-title" style="box-sizing: border-box; color:
rgb(33, 63, 77); margin: 0px 0px 8px; font-size: 18px;
font-weight: bold; text-shadow: rgba(255, 255, 255, 0.498039)
0px 1px; font-family: Helvetica, arial, nimbussansl,
liberationsans, freesans, clean, sans-serif, 'Segoe UI Emoji',
'Segoe UI Symbol'; font-style: normal; font-variant: normal;
letter-spacing: normal; orphans: auto; text-align: start;
text-indent: 0px; text-transform: none; white-space: normal;
widows: auto; word-spacing: 0px; -webkit-text-stroke-width:
0px;">st/nine: Always use user constant buffers</p>
<div class="commit-desc" style="box-sizing: border-box; display:
block; margin: -5px 0px 10px; color: rgb(51, 51, 51);
font-family: Helvetica, arial, nimbussansl, liberationsans,
freesans, clean, sans-serif, 'Segoe UI Emoji', 'Segoe UI
Symbol'; font-size: 12.727272033691406px; font-style: normal;
font-variant: normal; font-weight: normal; letter-spacing:
normal; line-height: 16.545454025268555px; orphans: auto;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px;">
<pre style="box-sizing: border-box; overflow: visible; font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 13px; margin: 10px 0px; font-style: normal; font-variant: normal; font-weight: normal; line-height: 1.45; max-width: 100%; color: rgb(89, 96, 99); white-space: pre-wrap; text-shadow: rgba(255, 255, 255, 0.498039) 0px 1px; word-wrap: break-word;">We had several reports of users hitting bugs
with the other path to upload constants,
and switching to the user constant buffer
path solves the bugs.
User constant buffers are expected to be slower
for Nvidia cards, so ideally this patch should be
reverted when the path is fixed.</pre>
</div>
<br>
I add this patch to the list of patches I will merge today.<br>
<br>
Axel DAvy<br>
<br>
On 21/08/2015 13:05, Krzysztof A. Sobiecki wrote :<br>
</div>
<blockquote cite="mid:87r3mw7vgf.fsf@gmail.com" type="cite">
<pre wrap="">st/nine: Disable NV path, it's broken right now.
Signed-off-by: Krzysztof Sobiecki <a class="moz-txt-link-rfc2396E" href="mailto:sobkas@gmail.com"><sobkas@gmail.com></a>
---
src/gallium/state_trackers/nine/device9.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/gallium/state_trackers/nine/device9.c b/src/gallium/state_trackers/nine/device9.c
index 673b7a4..555f11d 100644
--- a/src/gallium/state_trackers/nine/device9.c
+++ b/src/gallium/state_trackers/nine/device9.c
@@ -310,10 +310,12 @@ NineDevice9_ctor( struct NineDevice9 *This,
if (strstr(pScreen->get_name(pScreen), "AMD") ||
strstr(pScreen->get_name(pScreen), "ATI")) {
- This->prefer_user_constbuf = TRUE;
This->driver_bugs.buggy_barycentrics = TRUE;
}
+ /* Disable NV path for now, needs some fixes */
+ This->prefer_user_constbuf = TRUE;
+
tmpl.target = PIPE_BUFFER;
tmpl.format = PIPE_FORMAT_R8_UNORM;
tmpl.height0 = 1;
</pre>
</blockquote>
<br>
</body>
</html>