<p dir="ltr">Could you please debase this patch (probably rewrite)? I *think* it should fix <a href="https://bugs.freedesktop.org/show_bug.cgi?id=91716">https://bugs.freedesktop.org/show_bug.cgi?id=91716</a>.  What were the shader-db results for it?</p>
<div class="gmail_quote">On Aug 24, 2015 4:51 AM, "Antia Puentes" <<a href="mailto:apuentes@igalia.com">apuentes@igalia.com</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="quoted-text">Loads constants using integer as their register type, this is done<br>
for consistency with the FS backend.<br>
---<br>
 src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 4 ++--<br>
 1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp b/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp<br>
</div>index 632e409..23b2fab 100644<br>
<div class="quoted-text">--- a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp<br>
+++ b/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp<br>
@@ -456,7 +456,7 @@ void<br>
 vec4_visitor::nir_emit_load_const(nir_load_const_instr *instr)<br>
 {<br>
    dst_reg reg = dst_reg(GRF, alloc.allocate(1));<br>
-   reg.type =  BRW_REGISTER_TYPE_F;<br>
+   reg.type =  BRW_REGISTER_TYPE_D;<br>
<br>
</div>    unsigned remaining = brw_writemask_for_size(instr->def.num_components);<br>
<br>
@@ -477,7 +477,7 @@ vec4_visitor::nir_emit_load_const(nir_load_const_instr *instr)<br>
       }<br>
<br>
       reg.writemask = writemask;<br>
<div class="quoted-text">-      emit(MOV(reg, src_reg(instr->value.f[i])));<br>
+      emit(MOV(reg, src_reg(instr->value.i[i])));<br>
<br>
</div>       remaining &= ~writemask;<br>
<div class="elided-text">    }<br>
--<br>
2.1.0<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</div></blockquote></div>