<p dir="ltr"><br>
On Sep 5, 2015 6:27 AM, "Alejandro Piñeiro" <<a href="mailto:apinheiro@igalia.com">apinheiro@igalia.com</a>> wrote:<br>
><br>
> At that point the swizzle should be correct.<br>
> ---<br>
><br>
> First versions of commit 19cf9 included some manual<br>
> swizzle assignment that got removed after review [1],<br>
> as get_nir_src with the right number of components<br>
> should set a proper swizzle on most of the cases. This<br>
> one was overlooked.</p>
<p dir="ltr">Reviewed-by: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com">jason.ekstrand@intel.com</a>></p>
<p dir="ltr">> [1] <a href="http://lists.freedesktop.org/archives/mesa-dev/2015-July/089810.html">http://lists.freedesktop.org/archives/mesa-dev/2015-July/089810.html</a><br>
><br>
>  src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 1 -<br>
>  1 file changed, 1 deletion(-)<br>
><br>
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp<br>
> index 0ff298e..f6e59ce 100644<br>
> --- a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp<br>
> +++ b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp<br>
> @@ -2624,7 +2624,6 @@ vec4_visitor::emit_texture(ir_texture_opcode op,<br>
>             mrf = param_base;<br>
>             writemask = WRITEMASK_W;<br>
>          }<br>
> -         lod.swizzle = BRW_SWIZZLE_XXXX;<br>
>          emit(MOV(dst_reg(MRF, mrf, lod.type, writemask), lod));<br>
>        } else if (op == ir_txf) {<br>
>           emit(MOV(dst_reg(MRF, param_base, lod.type, WRITEMASK_W), lod));<br>
> --<br>
> 2.1.4<br>
><br>
> _______________________________________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</p>