<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 28, 2015 at 9:17 AM, Ilia Mirkin <span dir="ltr"><<a href="mailto:imirkin@alum.mit.edu" target="_blank">imirkin@alum.mit.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">On Fri, Aug 28, 2015 at 10:50 AM, Nanley Chery <<a href="mailto:nanleychery@gmail.com">nanleychery@gmail.com</a>> wrote:<br>
> From: Nanley Chery <<a href="mailto:nanley.g.chery@intel.com">nanley.g.chery@intel.com</a>><br>
><br>
> According to the extensions table and our glext headers, these<br>
> extensions are only supported in the core and compatibility<br>
> profiles of desktop GL.<br>
><br>
> Signed-off-by: Nanley Chery <<a href="mailto:nanley.g.chery@intel.com">nanley.g.chery@intel.com</a>><br>
> ---<br>
> src/mesa/main/glformats.c | 4 ++--<br>
> src/mesa/main/teximage.c | 6 ++++--<br>
> 2 files changed, 6 insertions(+), 4 deletions(-)<br>
><br>
> diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c<br>
> index ce66699..5f46770 100644<br>
> --- a/src/mesa/main/glformats.c<br>
> +++ b/src/mesa/main/glformats.c<br>
> @@ -1278,10 +1278,10 @@ _mesa_is_compressed_format(const struct gl_context *ctx, GLenum format)<br>
> case GL_COMPRESSED_SIGNED_LUMINANCE_LATC1_EXT:<br>
> case GL_COMPRESSED_LUMINANCE_ALPHA_LATC2_EXT:<br>
> case GL_COMPRESSED_SIGNED_LUMINANCE_ALPHA_LATC2_EXT:<br>
> - return ctx->API == API_OPENGL_COMPAT<br>
> + return _mesa_is_desktop_gl(ctx)<br>
> && ctx->Extensions.EXT_texture_compression_latc;<br>
<br>
</span>Isn't luminance compat-only? The ext should probably be marked as GLL<br>
instead. Hopefully someone can confirm...<br>
<span class=""><br></span></blockquote><div>You're right. Looking at the 3.1 spec, luminance and alpha formats are deprecated and should be compat-only. I will create another patch to fix the table and the bug in the _mesa_base_tex_format.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">
> case GL_COMPRESSED_LUMINANCE_ALPHA_3DC_ATI:<br>
> - return ctx->API == API_OPENGL_COMPAT<br>
> + return _mesa_is_desktop_gl(ctx)<br>
> && ctx->Extensions.ATI_texture_compression_3dc;<br>
<br>
</span>Same for this.<br>
<span class=""><br></span></blockquote><div>Agreed.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">
> case GL_ETC1_RGB8_OES:<br>
> return _mesa_is_gles(ctx)<br>
> diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c<br>
> index bfb0858..33b3def 100644<br>
> --- a/src/mesa/main/teximage.c<br>
> +++ b/src/mesa/main/teximage.c<br>
> @@ -534,7 +534,8 @@ _mesa_base_tex_format( struct gl_context *ctx, GLint internalFormat )<br>
> }<br>
> }<br>
><br>
> - if (ctx->Extensions.EXT_texture_compression_latc) {<br>
> + if (_mesa_is_desktop_gl(ctx) &&<br>
> + ctx->Extensions.EXT_texture_compression_latc) {<br>
> switch (internalFormat) {<br>
> case GL_COMPRESSED_LUMINANCE_LATC1_EXT:<br>
> case GL_COMPRESSED_SIGNED_LUMINANCE_LATC1_EXT:<br>
> @@ -547,7 +548,8 @@ _mesa_base_tex_format( struct gl_context *ctx, GLint internalFormat )<br>
> }<br>
> }<br>
><br>
> - if (ctx->Extensions.ATI_texture_compression_3dc) {<br>
> + if (_mesa_is_desktop_gl(ctx) &&<br>
> + ctx->Extensions.ATI_texture_compression_3dc) {<br>
> switch (internalFormat) {<br>
> case GL_COMPRESSED_LUMINANCE_ALPHA_3DC_ATI:<br>
> return GL_LUMINANCE_ALPHA;<br>
> --<br>
> 2.5.0<br>
><br>
</span>> _______________________________________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div><br></div></div>