<p dir="ltr"><br>
On Oct 8, 2015 4:03 PM, "Roland Scheidegger" <<a href="mailto:sroland@vmware.com">sroland@vmware.com</a>> wrote:<br>
><br>
> Was that because stencil used sampler 1 but sview 0 which looks<br>
> definitely wrong as there needs o be a 1:1 mapping between these when<br>
> the tex opcodes are used?</p>
<p dir="ltr">I don't remember how the SVIEW declarations work. It was TEX and there were 2 declarations, one was float and the other one was int. I think it's only required for freedreno with TEX.</p>
<p dir="ltr">Marek</p>
<p dir="ltr">><br>
> Roland<br>
><br>
> Am 08.10.2015 um 10:45 schrieb Marek Olšák:<br>
> > The problem was that it declared SVIEW but llvmpipe didn't like that for<br>
> > some reason.<br>
> ><br>
> > Marek<br>
> ><br>
> > On Oct 8, 2015 5:12 AM, "Roland Scheidegger" <<a href="mailto:sroland@vmware.com">sroland@vmware.com</a><br>
> > <mailto:<a href="mailto:sroland@vmware.com">sroland@vmware.com</a>>> wrote:<br>
> ><br>
> > Am 08.10.2015 um 02:02 schrieb Marek Olšák:<br>
> > > Hi Brian,<br>
> > ><br>
> > > This is the commit that broke DrawPixels on llvmpipe, but not radeonsi<br>
> > > and softpipe. It's fixed in v2, which is attached.<br>
> > ><br>
> > > Marek<br>
> > ><br>
> > > On Tue, Oct 6, 2015 at 3:26 AM, Marek Olšák <<a href="mailto:maraeo@gmail.com">maraeo@gmail.com</a><br>
> > <mailto:<a href="mailto:maraeo@gmail.com">maraeo@gmail.com</a>>> wrote:<br>
> > >> From: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a> <mailto:<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>>><br>
> > >><br>
> > >> - there is no connection to user fragment shaders, so having these as<br>
> > >> shader variants makes no sense<br>
> > >> - don't use Mesa IR, use TGSI<br>
> > >> - don't create gl_fragment_program, just create the shader CSO<br>
> > >> ---<br>
> > >><br>
> ><br>
> > I don't quite get from the differences, was the shader actually<br>
> > incorrect or is this something which should be fixed in llvmpipe?<br>
> ><br>
> > Roland<br>
> ><br>
><br>
</p>