<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 20, 2015 at 8:37 AM, Marek Olšák <span dir="ltr"><<a href="mailto:maraeo@gmail.com" target="_blank">maraeo@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">NAK. I'd like this extension in compatibility contexts. The fact the<br> spec requires OpenGL 3.1 was just authors' laziness.<br> <br></blockquote><div><br></div><div>I had thought it might be the case that some specs may unecessarily require a certain version,<br></div><div>when in fact a longer list of dependencies would suffice instead. I'll look into this issue. If it's<br>the right way to go, I can allow all versions of GL compatibility by simply replacing the '31' <br>with 'GLL' in a v2.<br></div><div><br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> Marek<br> <div><div><br> On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery <<a href="mailto:nanleychery@gmail.com" target="_blank">nanleychery@gmail.com</a>> wrote:<br> > From: Nanley Chery <<a href="mailto:nanley.g.chery@intel.com" target="_blank">nanley.g.chery@intel.com</a>><br> ><br> > Stop leaks into the following contexts:<br> > * GLES in _mesa_target_can_be_compressed().<br> > * Pre-3.1 GL legacy versions in all uses.<br> ><br> > The extension spec lists OpenGL 3.1 as required, so update the extension<br> > table accordingly.<br> ><br> > Signed-off-by: Nanley Chery <<a href="mailto:nanley.g.chery@intel.com" target="_blank">nanley.g.chery@intel.com</a>><br> > ---<br> > src/mesa/main/extensions_table.h | 2 +-<br> > src/mesa/main/glformats.c | 3 +--<br> > src/mesa/main/teximage.c | 2 +-<br> > 3 files changed, 3 insertions(+), 4 deletions(-)<br> ><br> > diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h<br> > index cf6eed7..62e0804 100644<br> > --- a/src/mesa/main/extensions_table.h<br> > +++ b/src/mesa/main/extensions_table.h<br> > @@ -93,7 +93,7 @@ EXT(ARB_texture_buffer_object , ARB_texture_buffer_object<br> > EXT(ARB_texture_buffer_object_rgb32 , ARB_texture_buffer_object_rgb32 , x , GLC, x , x , 2009)<br> > EXT(ARB_texture_buffer_range , ARB_texture_buffer_range , x , GLC, x , x , 2012)<br> > EXT(ARB_texture_compression , dummy_true , GLL, x , x , x , 2000)<br> > -EXT(ARB_texture_compression_bptc , ARB_texture_compression_bptc , GLL, GLC, x , x , 2010)<br> > +EXT(ARB_texture_compression_bptc , ARB_texture_compression_bptc , 31, GLC, x , x , 2010)<br> > EXT(ARB_texture_compression_rgtc , ARB_texture_compression_rgtc , GLL, GLC, x , x , 2004)<br> > EXT(ARB_texture_cube_map , ARB_texture_cube_map , GLL, x , x , x , 1999)<br> > EXT(ARB_texture_cube_map_array , ARB_texture_cube_map_array , GLL, GLC, x , x , 2009)<br> > diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c<br> > index 9134d7d..542dcfc 100644<br> > --- a/src/mesa/main/glformats.c<br> > +++ b/src/mesa/main/glformats.c<br> > @@ -1327,8 +1327,7 @@ _mesa_is_compressed_format(const struct gl_context *ctx, GLenum format)<br> > case MESA_FORMAT_LAYOUT_ETC2:<br> > return _mesa_is_gles3(ctx) || ctx->Extensions.ARB_ES3_compatibility;<br> > case MESA_FORMAT_LAYOUT_BPTC:<br> > - return _mesa_is_desktop_gl(ctx) &&<br> > - ctx->Extensions.ARB_texture_compression_bptc;<br> > + return _mesa_has_ARB_texture_compression_bptc(ctx);<br> > case MESA_FORMAT_LAYOUT_ASTC:<br> > return _mesa_has_KHR_texture_compression_astc_ldr(ctx);<br> > default:<br> > diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c<br> > index c14f941..7910fe7 100644<br> > --- a/src/mesa/main/teximage.c<br> > +++ b/src/mesa/main/teximage.c<br> > @@ -1387,7 +1387,7 @@ _mesa_target_can_be_compressed(const struct gl_context *ctx, GLenum target,<br> > return write_error(error, GL_INVALID_OPERATION);<br> > break;<br> > case MESA_FORMAT_LAYOUT_BPTC:<br> > - target_can_be_compresed = ctx->Extensions.ARB_texture_compression_bptc;<br> > + target_can_be_compresed = _mesa_has_ARB_texture_compression_bptc(ctx);<br> > break;<br> > case MESA_FORMAT_LAYOUT_ASTC:<br> > target_can_be_compresed =<br> > --<br> > 2.6.1<br> ><br> </div></div>> _______________________________________________<br> > mesa-dev mailing list<br> > <a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br> > <a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br> </blockquote></div><br></div></div>