<p dir="ltr"><br>
On Oct 21, 2015 10:28 AM, "Jason Ekstrand" <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> wrote:<br>
><br>
> On Wed, Oct 21, 2015 at 1:29 AM, Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>> wrote:<br>
> > On Monday, October 12, 2015 02:49:03 PM Kenneth Graunke wrote:<br>
> >> In the vec4 backend, we have a vec4_instruction::urb_write_flags field.<br>
> >> There are many kinds of flags for SIMD4x2 messages.<br>
> >><br>
> >> However, there are really only two (per-slot offset, use channel masks)<br>
> >> for SIMD8 messages. Rather than adding a boolean flag for per-slot<br>
> >> offsets (polluting all instructions), I decided to just make three new<br>
> >> opcodes.<br>
> >><br>
> >> Signed-off-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>><br>
> >> ---<br>
> >> src/mesa/drivers/dri/i965/brw_defines.h | 3 +++<br>
> >> src/mesa/drivers/dri/i965/brw_fs.cpp | 9 +++++++++<br>
> >> src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 11 +++++++++++<br>
> >> src/mesa/drivers/dri/i965/brw_inst.h | 1 +<br>
> >> src/mesa/drivers/dri/i965/brw_shader.cpp | 9 +++++++++<br>
> >> 5 files changed, 33 insertions(+)<br>
> >><br>
> >> Here's the rest of the series that didn't get reviewed last time,<br>
> >> rebased on Jason's compiler reworks.<br>
> ><br>
> > Jason landed yet more compiler reworks. I've pushed a rebased copy<br>
> > to the 'simd8gs' branch of ~kwg/mesa. Code got shuffled between<br>
> > functions or header files, so some of it didn't textually apply, but<br>
> > the new code isn't significantly different. I've verified that it<br>
> > still builds and passes Piglit.<br>
> ><br>
> > Jason has yet *more* compiler reworks on the mailing list. I've<br>
> > preemptively rebased on those and pushed that to my tree as well.<br>
> > It's the 'simd8gs-rebase-rebase' branch. That branch doesn't<br>
> > compile, however - with the roundabout vec4/fs include hell, it's<br>
> > somehow getting an incomplete type for "struct brw_gs_compile".<br>
> > I didn't spend the time to figure out why. Other work to do.<br>
><br>
> You didn't have to do that...<br>
><br>
> Anyway, I'll poke at it and get the include stuff sorted.</p>
<p dir="ltr">I just pushed a rebased version to my freedesktop repo in the wip/simd8gs branch.</p>
<p dir="ltr">--Jason</p>