<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [softpipe] piglit egl-create-context-valid-flag-forward-compatible-gl regression" href="https://bugs.freedesktop.org/show_bug.cgi?id=92552#c10">Comment # 10</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [softpipe] piglit egl-create-context-valid-flag-forward-compatible-gl regression" href="https://bugs.freedesktop.org/show_bug.cgi?id=92552">bug 92552</a> from <a class="email" href="mailto:ystreet00@gmail.com" title="Matthew Waters <ystreet00@gmail.com>"> Matthew Waters</a> <pre>(In reply to Ian Romanick from <a href="show_bug.cgi?id=92552#c9">comment #9</a>) > Comment on <a href="attachment.cgi?id=119006" name="attach_119006" title="egl: distnguish between unsupported api vs capabilities for EGL_CONTEXT_FLAGS">attachment 119006</a> <a href="attachment.cgi?id=119006&action=edit" title="egl: distnguish between unsupported api vs capabilities for EGL_CONTEXT_FLAGS">[details]</a> <a href='page.cgi?id=splinter.html&bug=92552&attachment=119006'>[review]</a> [review] > egl: distnguish between unsupported api vs capabilities for EGL_CONTEXT_FLAGS > > Review of <a href="attachment.cgi?id=119006" name="attach_119006" title="egl: distnguish between unsupported api vs capabilities for EGL_CONTEXT_FLAGS">attachment 119006</a> <a href="attachment.cgi?id=119006&action=edit" title="egl: distnguish between unsupported api vs capabilities for EGL_CONTEXT_FLAGS">[details]</a> <a href='page.cgi?id=splinter.html&bug=92552&attachment=119006'>[review]</a> [review]: > ----------------------------------------------------------------- > > There are a few things wrong with this patch. First, you can't check the > version when you see EGL_CONTEXT_FLAGS in the attribs list because the > application could specify the requested version after flags. This should > not generate an error: > > EGL_CONTEXT_FLAGS, EGL_CONTEXT_OPENGL_FORWARD_COMPATIBLE_BIT_KHR, > EGL_CONTEXT_CLIENT_VERSION, 3, > 0 Right, will fix. > Second, it is not correct to generate EGL_BAD_MATCH for > EGL_CONTEXT_OPENGL_ROBUST_ACCESS_BIT_KHR when > EGL_EXT_create_context_robustness is not supported. Think of it this way... > if we deleted all support and knowledge of > EGL_EXT_create_context_robustness, what error would be generated? Default > case in the switch statement says EGL_BAD_ATTRIBUTE. Not sure what you're trying to say here. Couple of interpretations: 1. Unknown bit in EGL_CONTEXT_FLAGS -> specs are pretty clear that EGL_BAD_ATTRIBUTE should be returned 2. EGL_CONTEXT_OPENGL_ROBUST_ACCESS_BIT_KHR is only defined for OpenGL contexts (not ES) -> taken care of previously and will return EGL_BAD_ATTRIBUTE. 3. Removing support for EGL_EXT_create_context_robustness is not the same as removing support for GL_ARB_robustness. My question then is, do we have a way we can check for GL_ARB_robustness from the egl code or is it always (not?) supported?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>