<p dir="ltr"><br>
On Nov 11, 2015 9:10 PM, "Matt Turner" <<a href="mailto:mattst88@gmail.com">mattst88@gmail.com</a>> wrote:<br>
><br>
> On Thu, Nov 5, 2015 at 9:44 PM, Kristian Høgsberg Kristensen<br>
> <<a href="mailto:krh@bitplanet.net">krh@bitplanet.net</a>> wrote:<br>
> > diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp<br>
> > index e4e4a3f..5584470 100644<br>
> > --- a/src/glsl/ast_function.cpp<br>
> > +++ b/src/glsl/ast_function.cpp<br>
> > @@ -376,12 +368,8 @@ fix_parameter(void *mem_ctx, ir_rvalue *actual, const glsl_type *formal_type,<br>
> ><br>
> >     ir_rvalue *lhs = actual;<br>
> >     if (expr != NULL && expr->operation == ir_binop_vector_extract) {<br>
> > -      rhs = new(mem_ctx) ir_expression(ir_triop_vector_insert,<br>
> > -                                       expr->operands[0]->type,<br>
> > -                                       expr->operands[0]->clone(mem_ctx, NULL),<br>
> > -                                       rhs,<br>
> > -                                       expr->operands[1]->clone(mem_ctx, NULL));<br>
> > -      lhs = expr->operands[0]->clone(mem_ctx, NULL);<br>
> > +      lhs == new(mem_ctx) ir_dereference_array(expr->operands[0]->clone(mem_ctx, NULL),<br>
> > +                                               expr->operands[1]->clone(mem_ctx, NULL));<br>
><br>
><br>
> I'm getting<br>
><br>
> ../../../mesa/src/glsl/ast_function.cpp: In function ‘void<br>
> fix_parameter(void*, ir_rvalue*, const glsl_type*, exec_list*,<br>
> exec_list*, bool)’:<br>
> ../../../mesa/src/glsl/ast_function.cpp:372:88: warning: right operand<br>
> of comma operator has no effect [-Wunused-value]<br>
><br>
> expr->operands[1]->clone(mem_ctx, NULL));<br>
><br>
> from this, but I can't interpret the warning.<br>
></p>
<p dir="ltr">Probably one equal sign too many...</p>
<p dir="ltr">  -ilia</p>