<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 17, 2015 at 12:37 PM, Oded Gabbay <span dir="ltr"><<a href="mailto:oded.gabbay@gmail.com" target="_blank">oded.gabbay@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Tue, Nov 17, 2015 at 6:15 PM, Emil Velikov <<a href="mailto:emil.l.velikov@gmail.com">emil.l.velikov@gmail.com</a>> wrote:<br>
> On 17 November 2015 at 16:02, Oded Gabbay <<a href="mailto:oded.gabbay@gmail.com">oded.gabbay@gmail.com</a>> wrote:<br>
>> This patch makes sure that if we use altivec (VMX) instructions, we don't<br>
>> use VSX instructions as well, as this cause piglit tests to fail<br>
>><br>
>> For more details, see: <a href="https://llvm.org/bugs/show_bug.cgi?id=25503#c7" rel="noreferrer" target="_blank">https://llvm.org/bugs/show_bug.cgi?id=25503#c7</a><br>
>><br>
>> With this patch, ppc64le reaches parity with x86-64 as far as piglit test<br>
>> suite is concerned.<br>
>><br>
>> v2:<br>
>> - Added check that we have at least LLVM 3.4<br>
>> - Added the LLVM bug URL as a comment in the code<br>
>><br>
>> Signed-off-by: Oded Gabbay <<a href="mailto:oded.gabbay@gmail.com">oded.gabbay@gmail.com</a>><br>
>> Cc: "11.0" <<a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a>><br>
>> ---<br>
>> src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 4 ++++<br>
>> 1 file changed, 4 insertions(+)<br>
>><br>
>> diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp<br>
>> index 7bda118..152593a 100644<br>
>> --- a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp<br>
>> +++ b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp<br>
>> @@ -536,6 +536,10 @@ lp_build_create_jit_compiler_for_module(LLVMExecutionEngineRef *OutJIT,<br>
>><br>
>> #if defined(PIPE_ARCH_PPC)<br>
>> MAttrs.push_back(util_cpu_caps.has_altivec ? "+altivec" : "-altivec");<br>
>> +#if HAVE_LLVM >= 0x0304<br>
>> + /* See LLVM bug <a href="https://llvm.org/bugs/show_bug.cgi?id=25503#c7" rel="noreferrer" target="_blank">https://llvm.org/bugs/show_bug.cgi?id=25503#c7</a> */<br>
>> + MAttrs.push_back("-vsx");<br>
> The commit message does not reflect what the patch actually does. I<br>
> cannot object against the patch in any way, although the two should be<br>
> in sync imho.<br>
><br>
> Base of a very quick look at the llvm bug, I'm leaning that the commit<br>
> msg is correct and the patch is off ?<br>
><br>
> Thanks<br>
> Emil<br>
<br>
</div></div>Hmm, I'm not sure I understand what you mean.<br>
<br>
The commit message says: "This patch makes sure that if we use altivec<br>
<span class="">(VMX) instructions, we don't<br>
use VSX instructions as well, as this cause piglit tests to fail"<br>
<br>
</span>And the patch itself disables the VSX attribute in LLVM backend in<br>
case we use Altivec (VMX) - meaning that no VSX instructions will be<br>
generated alongside Altivec instructions.<br>
<br>
So unless I completely misunderstood something, the commit message and<br>
the patch match.<br></blockquote><div><br></div><div>sorry to meddle. the commit message suggests that you only want to disable vsx if altivec is enabled. However, the patch adds -vsx unconditionally. Do you want to ever have "-altivec -vsx"?</div><div><br></div><div>Jan</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
The llvm bug description maybe a little misleading, because I started<br>
it last week and then I had a different impression. But that's why I<br>
pointed to comment #7 which is where I wrote the updated description,<br>
which matches this patch (workaround).<br>
<span class="HOEnZb"><font color="#888888"><br>
Oded<br>
</font></span><div class="HOEnZb"><div class="h5">_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</div></div></blockquote></div><br></div></div>