On Wed, Nov 18, 2015 at 3:47 PM, Matt Turner <<a href="mailto:mattst88@gmail.com">mattst88@gmail.com</a>> wrote: > > On Wed, Nov 18, 2015 at 3:01 PM, Nanley Chery <<a href="mailto:nanleychery@gmail.com">nanleychery@gmail.com</a>> wrote: > > From: Nanley Chery <<a href="mailto:nanley.g.chery@intel.com">nanley.g.chery@intel.com</a>> > > > > Make it easier to determine where to add new extensions. > > Performed with the vim sort command. > > Well, I think I'm obligated to review such a patch :) > Glad to get your review. It was inspired by your earlier review feedback after all. > > > Signed-off-by: Nanley Chery <<a href="mailto:nanley.g.chery@intel.com">nanley.g.chery@intel.com</a>> > > --- > > src/mesa/main/extensions_table.h | 173 +++++++++++++++++++++------------------ > > 1 file changed, 92 insertions(+), 81 deletions(-) > > > > diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h > > index d12fd9f..4b42863 100644 > > --- a/src/mesa/main/extensions_table.h > > +++ b/src/mesa/main/extensions_table.h > > @@ -1,8 +1,30 @@ > > +/* The extension table is alphabetically sorted by the extension name string column. */ > > + > > #define GLL 0 > > #define GLC 0 > > #define ES1 0 > > #define ES2 0 > > #define x ~0 > > I'd probably put a blank line between the last #define and the first EXT(...) > Sure, I'll include one. > > I trust sort, so > > Reviewed-by: Matt Turner <<a href="mailto:mattst88@gmail.com">mattst88@gmail.com</a>> > > > > +EXT(3DFX_texture_compression_FXT1 , TDFX_texture_compression_FXT1 , GLL, GLC, x , x , 1999)