<div dir="ltr">Hi<div><br></div><div>These three commits have stopped Plasma5's kwin working on my skylake system</div><div><br></div><div>Reverting back to <span style="font-family:monospace"><span style="color:rgb(0,0,0)">7752bbc44e78e982de3cd4c34862adc38a338234 </span></span>fixed it for me<div class="gmail_quote"><div><br></div><div>I can send you more details / raise a bug if you like</div><div><br></div><div>Cheers</div><div><br></div><div>Mike</div><div dir="ltr"><br></div><div dir="ltr">On Sat, 12 Dec 2015 at 20:56 Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Friday, December 11, 2015 12:32:18 PM Neil Roberts wrote:<br>
> Previously if the visual didn't have an alpha channel then it would<br>
> pick a format that is not sRGB-capable. I don't think there's any<br>
> reason not to always have an sRGB-capable visual. Since 28090b30 there<br>
> are now visuals advertised without an alpha channel which means that<br>
> games that don't request alpha bits in the config would end up without<br>
> an sRGB-capable visual. This was breaking supertuxkart which assumes<br>
> the winsys buffer is always sRGB-capable.<br>
><br>
> The previous code always used an RGBA format if the visual config<br>
> itself was marked as sRGB-capable regardless of whether the visual has<br>
> alpha bits. I think we don't actually advertise any sRGB-capable<br>
> visuals (but we just use sRGB formats anyway) so it shouldn't make any<br>
> difference. However this patch also changes it to use RGBX if an<br>
> sRGB-capable visual is requested without alpha bits for consistency.<br>
><br>
> Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=92759" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=92759</a><br>
> Cc: "11.0 11.1" <<a href="mailto:mesa-stable@lists.freedesktop.org" target="_blank">mesa-stable@lists.freedesktop.org</a>><br>
> Cc: Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu" target="_blank">imirkin@alum.mit.edu</a>><br>
> Suggested-by: Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu" target="_blank">imirkin@alum.mit.edu</a>><br>
> ---<br>
> src/mesa/drivers/dri/i965/intel_screen.c | 13 ++++++-------<br>
> 1 file changed, 6 insertions(+), 7 deletions(-)<br>
<br>
The whole series is:<br>
Reviewed-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org" target="_blank">kenneth@whitecape.org</a>><br>
<br>
We definitely should have the same behavior regardless of whether the<br>
config has an alpha channel. So, this is good.<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div></div></div>