<div dir="ltr">Hi, shouldn't the check be the following condition instead:<br>hevc->ReferenceFrames[i].flags & VA_PICTURE_HEVC_INVALID ||<br>hevc->ReferenceFrames[i].picture_id == VA_INVALID_SURFACE<br>?<br><div class="gmail_extra"><br><div class="gmail_quote">On 11 December 2015 at 12:33, Christian König <span dir="ltr"><<a href="mailto:deathsimple@vodafone.de" target="_blank">deathsimple@vodafone.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Christian König <<a href="mailto:christian.koenig@amd.com">christian.koenig@amd.com</a>><br>
<br>
The picture id in this case is a VA-API surface handle, checking<br>
for a certain value can't be correct.<br>
<br>
Signed-off-by: Christian König <<a href="mailto:christian.koenig@amd.com">christian.koenig@amd.com</a>><br>
---<br>
src/gallium/state_trackers/va/picture_hevc.c | 5 -----<br>
1 file changed, 5 deletions(-)<br>
<br>
diff --git a/src/gallium/state_trackers/va/picture_hevc.c b/src/gallium/state_trackers/va/picture_hevc.c<br>
index dc66b0f..28743ee 100644<br>
--- a/src/gallium/state_trackers/va/picture_hevc.c<br>
+++ b/src/gallium/state_trackers/va/picture_hevc.c<br>
@@ -159,11 +159,6 @@ void vlVaHandlePictureParameterBufferHEVC(vlVaDriver *drv, vlVaContext *context,<br>
for (i = 0 ; i < 15 ; i++) {<br>
context->desc.h265.PicOrderCntVal[i] = hevc->ReferenceFrames[i].pic_order_cnt;<br>
<br>
- unsigned int index = hevc->ReferenceFrames[i].picture_id & 0x7F;<br>
-<br>
- if (index == 0x7F)<br>
- continue;<br>
-<br>
vlVaGetReferenceFrame(drv, hevc->ReferenceFrames[i].picture_id, &context->desc.h265.ref[i]);<br>
<br>
if ((hevc->ReferenceFrames[i].flags & VA_PICTURE_HEVC_RPS_ST_CURR_BEFORE) && (iBefore < 8)) {<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.5.0<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>