<p dir="ltr"><br>
On Dec 14, 2015 3:34 PM, "Ian Romanick" <<a href="mailto:idr@freedesktop.org">idr@freedesktop.org</a>> wrote:<br>
><br>
> From: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>><br>
><br>
> nir/nir_constant_expressions.c:290:25: warning: unused parameter 'num_components' [-Wunused-parameter]<br>
> evaluate_ball3(unsigned num_components, nir_const_value *_src)<br>
> ^<br>
> nir/nir_constant_expressions.c: In function 'evaluate_fddx':<br>
> nir/nir_constant_expressions.c:1282:57: warning: unused parameter '_src' [-Wunused-parameter]<br>
> evaluate_fddx(unsigned num_components, nir_const_value *_src)<br>
> ^<br>
><br>
> Number of total warnings in my build reduced from 1575 to 1485<br>
> (reduction of 89).<br>
><br>
> Signed-off-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>><br>
> ---<br>
> src/glsl/nir/nir_constant_expressions.py | 10 ++++++++++<br>
> 1 file changed, 10 insertions(+)<br>
><br>
> diff --git a/src/glsl/nir/nir_constant_expressions.py b/src/glsl/nir/nir_constant_expressions.py<br>
> index 81dd67f..a83c12e 100644<br>
> --- a/src/glsl/nir/nir_constant_expressions.py<br>
> +++ b/src/glsl/nir/nir_constant_expressions.py<br>
> @@ -248,6 +248,16 @@ evaluate_${name}(unsigned num_components, nir_const_value *_src)<br>
> % endfor<br>
> };<br>
> % endfor<br>
> + % if op.output_size != 0 or "src" not in op.const_expr:<br>
> +<br>
> + /* Silence compiler warnings. */<br>
> + % if op.output_size != 0:<br>
> + (void) num_components;<br>
> + % endif<br>
> + % if "src" not in op.const_expr:<br>
> + (void) _src;<br>
> + % endif<br>
> + % endif</p>
<p dir="ltr">Can we just do the casts unconditionally at the top of the function with a comment that some parameters may be unused. I just don't want to add generator logic for it if we don't have to. Is that reasonable?</p>
<p dir="ltr">><br>
> % if op.output_size == 0:<br>
> ## For per-component instructions, we need to iterate over the<br>
> --<br>
> 2.5.0<br>
><br>
> _______________________________________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</p>