<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 23, 2015 at 1:12 PM, Ben Widawsky <span dir="ltr"><<a href="mailto:ben@bwidawsk.net" target="_blank">ben@bwidawsk.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Wed, Dec 23, 2015 at 12:09:44PM -0800, Anuj Phogat wrote:<br>
> Cc: Ben Widawsky <<a href="mailto:ben@bwidawsk.net">ben@bwidawsk.net</a>><br>
> Signed-off-by: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>><br>
> ---<br>
>  src/mesa/drivers/dri/i965/brw_state_dump.c | 7 +++++--<br>
>  1 file changed, 5 insertions(+), 2 deletions(-)<br>
><br>
> diff --git a/src/mesa/drivers/dri/i965/brw_state_dump.c b/src/mesa/drivers/dri/i965/brw_state_dump.c<br>
> index 3d3a6cf..facd4dc 100644<br>
> --- a/src/mesa/drivers/dri/i965/brw_state_dump.c<br>
> +++ b/src/mesa/drivers/dri/i965/brw_state_dump.c<br>
> @@ -319,10 +319,13 @@ dump_gen8_surface_state(struct brw_context *brw, uint32_t offset, int index)<br>
>               GET_FIELD(surf[4], GEN7_SURFACE_MIN_ARRAY_ELEMENT),<br>
>               GET_FIELD(surf[4], GEN7_SURFACE_RENDER_TARGET_VIEW_EXTENT) + 1,<br>
>               1 << GET_BITS(surf[4], 5, 3));<br>
> -   batch_out(brw, name, offset, 5, "x,y offset: %d,%d, min LOD: %d\n",<br>
> +   batch_out(brw, name, offset, 5, "x,y offset: %d,%d, min LOD: %d,"<br>
> +             " tr_mode: %d, mip tail: %d\n",<br>
>               GET_FIELD(surf[5], BRW_SURFACE_X_OFFSET),<br>
>               GET_FIELD(surf[5], BRW_SURFACE_Y_OFFSET),<br>
> -             GET_FIELD(surf[5], GEN7_SURFACE_MIN_LOD));<br>
> +             GET_FIELD(surf[5], GEN7_SURFACE_MIN_LOD),<br>
> +             GET_FIELD(surf[5], GEN9_SURFACE_TRMODE),<br>
> +             GET_FIELD(surf[5], GEN9_SURFACE_MIP_TAIL_START_LOD));<br>
>     batch_out(brw, name, offset, 6, "AUX pitch: %d qpitch: %d\n",<br>
>               GET_FIELD(surf[6], GEN8_SURFACE_AUX_QPITCH) << 2,<br>
>               GET_FIELD(surf[6], GEN8_SURFACE_AUX_PITCH) << 2);<br>
<br>
</div></div>Should be gen9 only... I don't think it's quite time yet to bother splitting out<br>
gen9 surface state, but maybe add "(gen9+)" to the actual print and then it's:<br>
Reviewed-by: Ben Widawsky <<a href="mailto:benjamin.widawsky@intel.com">benjamin.widawsky@intel.com</a>><br>
</blockquote></div><br></div><div class="gmail_extra">I'll add "(gen9+)".</div></div>