<p dir="ltr">Thanks!</p>
<div class="gmail_quote">On Jan 11, 2016 3:57 PM, "Ian Romanick" <<a href="mailto:idr@freedesktop.org">idr@freedesktop.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Yes, please!<br>
<br>
Reviewed-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>><br>
<br>
On 01/11/2016 02:48 PM, Matt Turner wrote:<br>
> If a Python codegen script failed, it would write a zero-byte file,<br>
> which on subsequent invocations of make would trick it into thinking the<br>
> file was appropriately generated.<br>
> ---<br>
> src/glsl/Makefile.am | 10 +++++-----<br>
> 1 file changed, 5 insertions(+), 5 deletions(-)<br>
><br>
> diff --git a/src/glsl/Makefile.am b/src/glsl/Makefile.am<br>
> index 95efdb3..ba7af7c 100644<br>
> --- a/src/glsl/Makefile.am<br>
> +++ b/src/glsl/Makefile.am<br>
> @@ -247,23 +247,23 @@ PYTHON_GEN = $(AM_V_GEN)$(PYTHON2) $(PYTHON_FLAGS)<br>
><br>
> nir/nir_builder_opcodes.h: nir/nir_opcodes.py nir/nir_builder_opcodes_h.py<br>
> $(MKDIR_GEN)<br>
> - $(PYTHON_GEN) $(srcdir)/nir/nir_builder_opcodes_h.py > $@<br>
> + $(PYTHON_GEN) $(srcdir)/nir/nir_builder_opcodes_h.py > $@ || ($(RM) $@; false)<br>
><br>
> nir/nir_constant_expressions.c: nir/nir_opcodes.py nir/nir_constant_expressions.py<br>
> $(MKDIR_GEN)<br>
> - $(PYTHON_GEN) $(srcdir)/nir/nir_constant_expressions.py > $@<br>
> + $(PYTHON_GEN) $(srcdir)/nir/nir_constant_expressions.py > $@ || ($(RM) $@; false)<br>
><br>
> nir/nir_opcodes.h: nir/nir_opcodes.py nir/nir_opcodes_h.py<br>
> $(MKDIR_GEN)<br>
> - $(PYTHON_GEN) $(srcdir)/nir/nir_opcodes_h.py > $@<br>
> + $(PYTHON_GEN) $(srcdir)/nir/nir_opcodes_h.py > $@ || ($(RM) $@; false)<br>
><br>
> nir/nir_opcodes.c: nir/nir_opcodes.py nir/nir_opcodes_c.py<br>
> $(MKDIR_GEN)<br>
> - $(PYTHON_GEN) $(srcdir)/nir/nir_opcodes_c.py > $@<br>
> + $(PYTHON_GEN) $(srcdir)/nir/nir_opcodes_c.py > $@ || ($(RM) $@; false)<br>
><br>
> nir/nir_opt_algebraic.c: nir/nir_opt_algebraic.py nir/nir_algebraic.py<br>
> $(MKDIR_GEN)<br>
> - $(PYTHON_GEN) $(srcdir)/nir/nir_opt_algebraic.py > $@<br>
> + $(PYTHON_GEN) $(srcdir)/nir/nir_opt_algebraic.py > $@ || ($(RM) $@; false)<br>
><br>
> nir_tests_control_flow_tests_SOURCES = \<br>
> nir/tests/control_flow_tests.cpp<br>
><br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div>