[Mesa-stable] [Mesa-dev] [PATCH] glsl: Rewrite and fix min/max to saturate optimization.

Abdiel Janulgue abdiel.janulgue at linux.intel.com
Wed Feb 25 00:18:10 PST 2015



On 02/24/2015 09:22 PM, Matt Turner wrote:
> There were some bugs, and the code was really difficult to follow. We
> would optimize
>
>     min(max(x, b), 1.0) into max(sat(x), b)
>
> but not pay attention to the order of min/max and also do
>
>     max(min(x, b), 1.0) into max(sat(x), b)
>
> Corrects four shaders from Champions of Regnum that do
>
>     min(max(x, 1), 10)
>
> Cc: "10.5" <mesa-stable at lists.freedesktop.org>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89180

Thanks for fixing this!

Reviewed-by: Abdiel Janulgue <abdiel.janulgue at linux.intel.com>


More information about the mesa-stable mailing list