[Mesa-stable] [PATCH 19/53] st/nine: Clamp color inputs for ps <= 2.0 at ps level instead of vs

Axel Davy axel.davy at ens.fr
Sun Jan 11 01:30:50 PST 2015


On 07/01/2015 17:36, Axel Davy wrote :
> Nine code was clamping color outputs for vs < 3,
> but msdn docs says it is done in the ps.
> Wine seems to clamp them at the vs level.
>
> It makes more sense to clamp at vs level for performance,
> but according to doc, ps 2.x shouldn't see clamping.
>
>
We have found a game using ps 2.x that didn't work well anymore
with this patch, so likely the documentation is wrong about ps 2.x
behaviour.

Since it is disallowed to use vs <= 2 with ps 3 and vs 3 with ps <= 2 
(except for software renderer),
then it is better for performance to clamp color outputs at vs <= 2 
level, which is what was doing
previous code.

So this patch is dropped.

Axel Davy


More information about the mesa-stable mailing list