On Aug 12, 2015 3:55 AM, "Oded Gabbay" <<a href="mailto:oded.gabbay@gmail.com">oded.gabbay@gmail.com</a>> wrote: > > Because we build here an array format, we don't need to swap the > bytes for big endian. > If it isn't an array format, the bytes will be swapped in > _mesa_format_convert. > > Signed-off-by: Oded Gabbay <<a href="mailto:oded.gabbay@gmail.com">oded.gabbay@gmail.com</a>> > Cc: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com">jason.ekstrand@intel.com</a>> > Cc: Iago Toral <<a href="mailto:itoral@igalia.com">itoral@igalia.com</a>> > Cc: "10.5 10.6" <<a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a>> > --- > src/mesa/main/glformats.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c > index c3fd734..07edb50 100644 > --- a/src/mesa/main/glformats.c > +++ b/src/mesa/main/glformats.c > @@ -2711,9 +2711,6 @@ _mesa_format_from_format_and_type(GLenum format, GLenum type) > normalized, num_channels, > swizzle[0], swizzle[1], swizzle[2], swizzle[3]); > > - if (!_mesa_little_endian()) > - array_format = _mesa_array_format_flip_channels(array_format); > - > return array_format; We might as well return the result of the MESA_ARRAY_FORMAT call directly and get rid of the temporary variable. Good find! --Jason > } > > -- > 2.4.3 > > _______________________________________________ > mesa-dev mailing list > <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> > <a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a>