<p dir="ltr">Reviewed-by: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com">jason.ekstrand@intel.com</a>></p>
<div class="gmail_quote">On Sep 2, 2015 11:28 PM, "Kenneth Graunke" <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">commit 472ef9a02f2e5c5d0caa2809cb736a0f4f0d4693 introduced code to<br>
change the types of SEL and MOV instructions for moves that simply<br>
"copy bits around". It didn't account for type conversion moves,<br>
however. So it would happily turn this:<br>
<br>
mov(8) vgrf6:D, -vgrf5:D<br>
mov(8) vgrf7:F, vgrf6:UD<br>
<br>
into this:<br>
<br>
mov(8) vgrf6:D, -vgrf5:D<br>
mov(8) vgrf7:D, -vgrf5:D<br>
<br>
which erroneously drops the conversion to float.<br>
<br>
Cc: "11.0 10.6" <<a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a>><br>
Signed-off-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>><br>
---<br>
src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 1 +<br>
1 file changed, 1 insertion(+)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp b/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp<br>
index 5445ad5..230b0ca 100644<br>
--- a/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp<br>
+++ b/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp<br>
@@ -279,6 +279,7 @@ static bool<br>
can_change_source_types(fs_inst *inst)<br>
{<br>
return !inst->src[0].abs && !inst->src[0].negate &&<br>
+ inst->dst.type == inst->src[0].type &&<br>
(inst->opcode == BRW_OPCODE_MOV ||<br>
(inst->opcode == BRW_OPCODE_SEL &&<br>
inst->predicate != BRW_PREDICATE_NONE &&<br>
--<br>
2.5.0<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div>