<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Am 01.02.2016 um 19:04 schrieb Leo Liu:<br>
</div>
<blockquote cite="mid:56AF9E37.3000305@amd.com" type="cite">
<br>
<br>
On 02/01/2016 12:59 PM, Ilia Mirkin wrote:
<br>
<blockquote type="cite">On Mon, Feb 1, 2016 at 12:35 PM, Leo Liu
<a class="moz-txt-link-rfc2396E" href="mailto:leo.liu@amd.com"><leo.liu@amd.com></a> wrote:
<br>
<blockquote type="cite">The scaling list should be filled out
with zig zag scan
<br>
<br>
v2: integrate zig zag scan for list 4x4 to vl(Christian)
<br>
<br>
Cc: "11.0 11.1" <a class="moz-txt-link-rfc2396E" href="mailto:mesa-stable@lists.freedesktop.org"><mesa-stable@lists.freedesktop.org></a>
<br>
Signed-off-by: Leo Liu <a class="moz-txt-link-rfc2396E" href="mailto:leo.liu@amd.com"><leo.liu@amd.com></a>
<br>
---
<br>
src/gallium/state_trackers/omx/vid_dec_h264.c | 6 ++++--
<br>
1 file changed, 4 insertions(+), 2 deletions(-)
<br>
<br>
diff --git a/src/gallium/state_trackers/omx/vid_dec_h264.c
b/src/gallium/state_trackers/omx/vid_dec_h264.c
<br>
index f66ed89..f17be91 100644
<br>
--- a/src/gallium/state_trackers/omx/vid_dec_h264.c
<br>
+++ b/src/gallium/state_trackers/omx/vid_dec_h264.c
<br>
@@ -35,6 +35,7 @@
<br>
#include "util/u_memory.h"
<br>
#include "util/u_video.h"
<br>
#include "vl/vl_rbsp.h"
<br>
+#include "vl/vl_zscan.h"
<br>
<br>
#include "entrypoint.h"
<br>
#include "vid_dec.h"
<br>
@@ -215,6 +216,7 @@ static void scaling_list(struct vl_rbsp
*rbsp, uint8_t *scalingList, unsigned si
<br>
}
<br>
<br>
for (i = 0; i < sizeOfScalingList; ++i ) {
<br>
+ unsigned scan = (sizeOfScalingList == 16) ?
vl_zscan_normal_16[i] : vl_zscan_normal[i];
<br>
</blockquote>
Perhaps determine the list just once rather than on each loop
iter?
<br>
Also (and more importantly) it appears like you forgot to add
<br>
vl_zscan_normal_16?
<br>
</blockquote>
<br>
patch 1 is sent, not sure why it haven't arrived.
<br>
</blockquote>
<br>
Yeah, patch #1 arrived a bit later for me as well. No idea why.<br>
<br>
I think we can leave optimizing the away which list to use to the
compiler, patches are Reviewed-by: Christian König
<a class="moz-txt-link-rfc2396E" href="mailto:christian.koenig@amd.com"><christian.koenig@amd.com></a><br>
<br>
Regards,<br>
Christian.<br>
<br>
<blockquote cite="mid:56AF9E37.3000305@amd.com" type="cite">
<br>
<br>
<blockquote type="cite">
<br>
<blockquote type="cite"> if (nextScale != 0) {
<br>
signed delta_scale = vl_rbsp_se(rbsp);
<br>
@@ -224,8 +226,8 @@ static void scaling_list(struct vl_rbsp
*rbsp, uint8_t *scalingList, unsigned si
<br>
return;
<br>
}
<br>
}
<br>
- scalingList[i] = nextScale == 0 ? lastScale :
nextScale;
<br>
- lastScale = scalingList[i];
<br>
+ scalingList[scan] = nextScale == 0 ? lastScale :
nextScale;
<br>
+ lastScale = scalingList[scan];
<br>
}
<br>
}
<br>
<br>
--
<br>
1.9.1
<br>
<br>
_______________________________________________
<br>
mesa-dev mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a>
<br>
<a class="moz-txt-link-freetext" href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a>
<br>
</blockquote>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
mesa-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>