[PATCH v2] altair-lte: increase timeout for +CFUN=4

[Dan Williams]

On Thu, 2013-08-15 at 11:28 -0700, Ben Chan wrote:
> Thanks!
> 
> While I was playing with the timeout, I wonder if it's a good idea to have
> a way to relax all timeouts and then profile the average/worst case time
> required for each AT/QMI/MBIM command.

Yeah, you could instrument the MMPort subclasses to cache the requested
timeout, but instead use like 240 or something, and then record what the
actual time was and stuff the [actual time, requested timeout, command]
into a table and then dump the results out on exit.  Maybe add some
analysis to that output for average/worst too.  The basic table
insertion/analysis stuff could go into MMPort, but the actual timing and
command determination stuff would have to be in the subclasses because
they know the protocol.

Dan

> Ben
> 
> 
> On Thu, Aug 15, 2013 at 11:26 AM, Dan Williams <dcbw at redhat.com> wrote:
> 
> > On Thu, 2013-08-15 at 11:12 -0700, Ben Chan wrote:
> > > ---
> > >  plugins/altair/mm-broadband-modem-altair-lte.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Pushed, thanks.
> >
> > Dan
> >
> > > diff --git a/plugins/altair/mm-broadband-modem-altair-lte.c
> > b/plugins/altair/mm-broadband-modem-altair-lte.c
> > > index 3c5ef6c..5260fa2 100644
> > > --- a/plugins/altair/mm-broadband-modem-altair-lte.c
> > > +++ b/plugins/altair/mm-broadband-modem-altair-lte.c
> > > @@ -74,7 +74,7 @@ modem_power_down (MMIfaceModem *self,
> > >  {
> > >      mm_base_modem_at_command (MM_BASE_MODEM (self),
> > >                                "+CFUN=4",
> > > -                              6,
> > > +                              20,
> > >                                FALSE,
> > >                                callback,
> > >                                user_data);
> >
> >
> >
> _______________________________________________
> ModemManager-devel mailing list
> ModemManager-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/modemmanager-devel