[PATCH] iface-modem-3gpp: add SubscriptionState property

Thieu Le thieule at chromium.org
Mon Oct 7 11:54:50 PDT 2013


On Mon, Oct 7, 2013 at 2:55 AM, Aleksander Morgado <aleksander at lanedo.com>wrote:

> On 02/10/13 23:14, Thieu Le wrote:
> > Added libmm-glib methods, updated mmcli and simple status and added
> gtk-doc documentation.
> >
>
> Just saw that I re-reviewed a previous version of this patch :) Still,
> the comments I said apply to this one as well, so please consider them.
>

I have addressed the following code review comments.  Did I miss something
on your list or was there another email with more comments?


On Sat, Sep 28, 2013 at 7:49 AM, Aleksander Morgado <aleksander at lanedo.com>
 wrote:

> Please also update:
>
>  * libmm-glib with the methods needed to access the new property.
>  * mmcli to show the property value when showing the modem status info
> (e.g. mmcli -m 0).
>  * the gtk-doc documentation with the new enum and methods.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/modemmanager-devel/attachments/20131007/5efbda1d/attachment.html>


More information about the ModemManager-devel mailing list