[RFT] CDMA SMS support in QMI modems

[Dan Williams]

On Thu, 2013-10-24 at 09:53 +0200, Aleksander Morgado wrote:
> Hey,
> 
> >>
> >> Is there any way to obscure the whole 3GPP vs. 3GPP thing, so that
> >> clients don't have to know what type of modem they're dealing with when
> >> they create an SMS?  Most clients just don't care, they just want to
> >> send a message.  Can we add the teleservice id only when sending if the
> >> modem is 3GPP2?  The teleservice id should probably default to 'wmt' for
> >> CDMA messages anyway, unless overridden by the caller.
> >>
> >> Here's what I did:
> >>
> >> # mmcli -m 0 --messaging-create-sms="text='CDMA test message##',number='+1<my phone #>'"
> >> Successfully created new SMS:
> >> 	/org/freedesktop/ModemManager1/SMS/0 (unknown)
> >> # mmcli -s 0 --send
> >> error: couldn't send the SMS: 'GDBus.Error:org.freedesktop.ModemManager1.Error.Core.Unsupported: Non-3GPP modem doesn't support 3GPP SMS'
> >>
> >> Since the message has to be created with "-m X" and thus has a modem, MM
> >> knows what the modem capabilities are.  In my case (Sierra 7750 forced
> >> to 1x/EVDO-only mode) there is no SIM object and the device has no 3GPP
> >> current capabilties.
> >>
> > 
> > I guess we can do this, yes. And if the modem is both 3GPP+3GPP2;
> > default to 3GPP. Will prepare a patch for the branch.
> > 
> 
> Pushed a fix to handle this.
> 
> >>
> >> Also, mailed you a data dump from SMS receipt that goes wrong, seems
> >> something isn't quite right with the "latin" encoding handling.
> >>
> > 
> > Ok, will look at it.
> 
> Pushed a fix to allow receiving SMS with latin encoding.
> 
> Let me know if they worked or not.

Latin and Unicode fixes work.  Thanks!  I'm happy to test ASCII digit
mode if you have a couple minutes to hack that in.

Dan