[PATCH] huawei: fix ^ICCID parsing

[Dan Williams]

On Wed, 2013-09-25 at 12:50 -0700, Ben Chan wrote:
> On Wed, Sep 25, 2013 at 12:04 PM, Dan Williams <dcbw at redhat.com> wrote:
> > On Wed, 2013-09-25 at 10:21 -0700, Ben Chan wrote:
> >> Checking the leading 89 digits is actually a better option. It should
> >> be a constant for now.
> >>
> >> Perhaps we can change mm_3gpp_parse_iccid to use the leading two
> >> digits to decide if swapping is needed?
> >
> > Sure, that sounds like a good solution for now.
> >
> 
> Aleksander / Dan, do you prefer to keep the flexibility to explicitly
> specify whether mm_3gpp_parse_iccid should swap the digits or not. Or
> are you comfortable with simply letting mm_3gpp_parse_iccid to decide
> based on the leading two digits? I'd propose the latter unless we're
> not so sure if the leading digits are always 89.

Looking at some relevant documents, I'm less sure the digits will always
be 89, though that still seems unlikely.  What we could do, however, is
warn in the logs if the first two digits were anything *other* than
89/98 so that at least we know if we do hit this case, and we can
re-visit it.  Perhaps we should ask the vendors eg Huawei if they ever
using testing SIMs that don't have a 89 prefix?  We dont' really want to
make life hard for them there.

Dan