[RFC] libmbim and libqmi mandatory for MM 1.6?

[Ben Chan]

Instead of using ifdefs in the code, perhaps we could partition the source
code/files in a way that the build process selects between a true mbim/qmi
implementation and a stub mbim/qmi implementation (which effectively
bypasses mbim/qmi).

We currently still bypass the qmi implementation in MM on certain ChromeOS
platforms due to the need to use some Gobi specific features.

Ben
On Jan 17, 2015 10:57 AM, "Aleksander Morgado" <aleksander at aleksander.es>
wrote:

> On Sat, Jan 17, 2015 at 3:33 PM, Marius Kotsbak <marius at kotsbak.com>
> wrote:
> >> Hey,
> >>
> >> I'd like to suggest removing the optional support for libqmi and
> >> libmbim in the next MM release, so that both libraries end up being
> >> mandatory. Most distributions already ship both libraries, and most
> >> new modems come with MBIM support, so I think it truly makes sense.
> >>
> >> Any comment?
> >
> > What I could think of is space restricted embedded devices/containers
> where
> > you want to strip down the pieces that you know are not in use.
> >
>
> That's a fair point.
>
> > What are the benefits of making it required?
>
> Less ifdefs everywhere mainly, cleaner code... I still would like to
> see if anyone builds MM without libmbim or libqmi lately.
>
> Anyway, again, that is a fair point. Actually, one option we could
> even take if we want that as a supported usecase is to allow choosing
> the plugins being built; see e.g.:
>
> https://bitbucket.org/mitchfoo/modemmanager/commits/6e11b5b9bd49e8b1ca9a2cf337028765764e0bc0
>
> Or even independent interfaces, e.g.:
>
> https://bitbucket.org/mitchfoo/modemmanager/commits/7e484dd31721482308a6c9215fd0afbc50ccfa91
>
> Now, that is a #ifdef nightmare...
>
> --
> Aleksander
> https://aleksander.es
> _______________________________________________
> ModemManager-devel mailing list
> ModemManager-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/modemmanager-devel/attachments/20150118/b277da14/attachment.html>