<div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

Instead of passing a MMBearerStatus value; it probably is a good idea to<br>
have a new enumeration considering other things. E.g. in the option/hso<br>
bearer we have report_connection_status() which is the method used by<br>
the modem object to notify about unsolicited messages received during<br>
connection/disconnection sequence. This method uses a new enum with the<br>
following values:<br>
<br>
typedef enum {<br>
    MM_BROADBAND_BEARER_HSO_CONNECTION_STATUS_UNKNOWN,<br>
    MM_BROADBAND_BEARER_HSO_CONNECTION_STATUS_CONNECTED,<br>
    MM_BROADBAND_BEARER_HSO_CONNECTION_STATUS_CONNECTION_FAILED,<br>
    MM_BROADBAND_BEARER_HSO_CONNECTION_STATUS_DISCONNECTED<br>
} MMBroadbandBearerHsoConnectionStatus;<br>
<br>
The generic report_status() could handle all these. Something like:<br>
<br>
typedef enum {<br>
    MM_BEARER_CONNECTION_STATUS_UNKNOWN,<br>
    MM_BEARER_CONNECTION_STATUS_CONNECTED,<br>
    MM_BEARER_CONNECTION_STATUS_CONNECTION_FAILED,<br>
    MM_BEARER_CONNECTION_STATUS_DISCONNECTING,<br>
    MM_BEARER_CONNECTION_STATUS_DISCONNECTED,<br>
} MMBearerConnectionStatus.<br>
<br>
The 'disconnecting' case could be used by the Huawei plugin to notify<br>
about a disconnection that will need further plugin action to finally<br>
report disconnected (see the other email).<br>
<div class=""><div class="h5"><br></div></div></blockquote><div><br></div><div>I guess you're proposing:</div><div>- getting rid of those custom connection status enum in mbm/hso/icera</div><div>- converting those custom mm_broadband_*_report_connection_status() in mbm/hso/icera to report_connection_status()</div>

<div>- instead of calling mm_bearer_report_* in those custom mm_broadband_*_report_connection_status(), call parent's report_connection_status</div><div><br></div><div>I think the changes make sense, but don't have those modems to verify such changes. Do you have those modems?</div>

<div><br></div><div> </div></div></div></div>