<div dir="ltr">btw, I had a typo in my commit message: <span style="font-family:arial,sans-serif;font-size:13px">fucntion -> </span><span style="font-family:arial,sans-serif;font-size:13px">function</span><div class="gmail_extra">
<br><br><div class="gmail_quote">On Wed, Mar 5, 2014 at 7:30 PM, Ben Chan <span dir="ltr"><<a href="mailto:benchan@chromium.org" target="_blank">benchan@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
hdr_subsys_state_info_ready() did not implement the GAsyncReadyCallback<br>
fucntion signature, which led to a crash. This patch fixes<br>
hdr_subsys_state_info_ready() to properly extract the QCDM response from<br>
the GAsyncResult object.<br>
---<br>
src/mm-broadband-modem.c | 6 ++++--<br>
1 file changed, 4 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/mm-broadband-modem.c b/src/mm-broadband-modem.c<br>
index b17be26..a987f85 100644<br>
--- a/src/mm-broadband-modem.c<br>
+++ b/src/mm-broadband-modem.c<br>
@@ -6324,14 +6324,16 @@ modem_cdma_get_hdr_state_finish (MMIfaceModemCdma *self,<br>
<br>
static void<br>
hdr_subsys_state_info_ready (MMPortSerialQcdm *port,<br>
- GByteArray *response,<br>
- GError *error,<br>
+ GAsyncResult *res,<br>
HdrStateContext *ctx)<br>
{<br>
QcdmResult *result;<br>
HdrStateResults *results;<br>
gint err = QCDM_SUCCESS;<br>
+ GError *error = NULL;<br>
+ GByteArray *response;<br>
<br>
+ response = mm_port_serial_qcdm_command_finish (port, res, &error);<br>
if (error) {<br>
g_simple_async_result_set_from_error (ctx->result, error);<br>
hdr_state_context_complete_and_free (ctx);<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.9.0.279.gdc9e3eb<br>
<br>
</font></span></blockquote></div><br></div></div>