<div dir="ltr">Hi Dan,<div>Thanks for taking a look.</div><div><br></div><div>Will you be able to rebase, or should I upload another version that does not conflict with Ben's patch?</div></div><div class="gmail_extra">

<br><br><div class="gmail_quote">On Wed, Jun 18, 2014 at 6:35 AM, Dan Williams <span dir="ltr"><<a href="mailto:dcbw@redhat.com" target="_blank">dcbw@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<div class="">On Mon, 2014-06-16 at 14:54 -0700, Prathmesh Prabhu Chromium wrote:<br>
> Hi,<br>
><br>
> This patch can only be pushed after the corresponding libmbim patch:<br>
> <a href="http://lists.freedesktop.org/archives/modemmanager-devel/2014-June/001282.html" target="_blank">http://lists.freedesktop.org/archives/modemmanager-devel/2014-June/001282.html</a><br>
<br>
</div>It also conflicts with a patch Ben sent last Monday; which already added<br>
the NOT_SUBSCRIBED error.  But yours does add the MISSING_OR_UNKNOWN_APN<br>
error which should definitely be useful and does require the libmbim<br>
patch.<br>
<br>
Dan<br>
<div><div class="h5"><br>
> Thanks,<br>
> Prathmesh<br>
><br>
><br>
><br>
> On Mon, Jun 16, 2014 at 2:52 PM, <<a href="mailto:pprabhu@chromium.org">pprabhu@chromium.org</a>> wrote:<br>
><br>
> > From: Prathmesh Prabhu <<a href="mailto:pprabhu@chromium.org">pprabhu@chromium.org</a>><br>
> ><br>
> > diff --git a/src/mm-modem-helpers-mbim.c b/src/mm-modem-helpers-mbim.c<br>
> > index 8060ace..900e1bb 100644<br>
> > --- a/src/mm-modem-helpers-mbim.c<br>
> > +++ b/src/mm-modem-helpers-mbim.c<br>
> > @@ -227,6 +227,15 @@ mm_mobile_equipment_error_from_mbim_nw_error<br>
> > (MbimNwError nw_error)<br>
> >          return g_error_new (MM_MOBILE_EQUIPMENT_ERROR,<br>
> >                              MM_MOBILE_EQUIPMENT_ERROR_GPRS_CONGESTION,<br>
> >                              "Congestion");<br>
> > +    case MBIM_NW_ERROR_MISSING_OR_UNKNOWN_APN:<br>
> > +        return g_error_new (MM_MOBILE_EQUIPMENT_ERROR,<br>
> > +<br>
> >  MM_MOBILE_EQUIPMENT_ERROR_GPRS_MISSING_OR_UNKNOWN_APN,<br>
> > +                            "Missing or unknown APN");<br>
> > +    case MBIM_NW_ERROR_REQUESTED_SERVICE_OPTION_NOT_SUBSCRIBED:<br>
> > +        return g_error_new (MM_MOBILE_EQUIPMENT_ERROR,<br>
> > +<br>
> >  MM_MOBILE_EQUIPMENT_ERROR_GPRS_SERVICE_OPTION_NOT_SUBSCRIBED,<br>
> > +                            "Requested service option not subscribed");<br>
> > +<br>
> >      default:<br>
> >          return g_error_new (MM_MOBILE_EQUIPMENT_ERROR,<br>
> >                              MM_MOBILE_EQUIPMENT_ERROR_GPRS_UNKNOWN,<br>
> > --<br>
> > 2.0.0.526.g5318336<br>
> ><br>
> ><br>
</div></div>> _______________________________________________<br>
> ModemManager-devel mailing list<br>
> <a href="mailto:ModemManager-devel@lists.freedesktop.org">ModemManager-devel@lists.freedesktop.org</a><br>
> <a href="http://lists.freedesktop.org/mailman/listinfo/modemmanager-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/modemmanager-devel</a><br>
<br>
<br>
</blockquote></div><br></div>