<div dir="ltr"><div>I rebased Prathmesh's patch. also updated the commit message with more details.</div></div><div class="gmail_extra"> <div class="gmail_quote">On Thu, Jun 19, 2014 at 2:09 AM, Aleksander Morgado <<a href="mailto:aleksander@aleksander.es" target="_blank">aleksander@aleksander.es</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">On 18/06/14 16:13, Prathmesh Prabhu Chromium wrote: > Hi Dan, > Thanks for taking a look. > > Will you be able to rebase, or should I upload another version that does > not conflict with Ben's patch? > </div>Please rebase yourself :) <div class="HOEnZb"><div class="h5"> > > On Wed, Jun 18, 2014 at 6:35 AM, Dan Williams <<a href="mailto:dcbw@redhat.com">dcbw@redhat.com</a>> wrote: > >> On Mon, 2014-06-16 at 14:54 -0700, Prathmesh Prabhu Chromium wrote: >>> Hi, >>> >>> This patch can only be pushed after the corresponding libmbim patch: >>> >> <a href="http://lists.freedesktop.org/archives/modemmanager-devel/2014-June/001282.html" target="_blank">http://lists.freedesktop.org/archives/modemmanager-devel/2014-June/001282.html</a> >> >> It also conflicts with a patch Ben sent last Monday; which already added >> the NOT_SUBSCRIBED error. But yours does add the MISSING_OR_UNKNOWN_APN >> error which should definitely be useful and does require the libmbim >> patch. >> >> Dan >> >>> Thanks, >>> Prathmesh >>> >>> >>> >>> On Mon, Jun 16, 2014 at 2:52 PM, <<a href="mailto:pprabhu@chromium.org">pprabhu@chromium.org</a>> wrote: >>> >>>> From: Prathmesh Prabhu <<a href="mailto:pprabhu@chromium.org">pprabhu@chromium.org</a>> >>>> >>>> diff --git a/src/mm-modem-helpers-mbim.c b/src/mm-modem-helpers-mbim.c >>>> index 8060ace..900e1bb 100644 >>>> --- a/src/mm-modem-helpers-mbim.c >>>> +++ b/src/mm-modem-helpers-mbim.c >>>> @@ -227,6 +227,15 @@ mm_mobile_equipment_error_from_mbim_nw_error >>>> (MbimNwError nw_error) >>>> return g_error_new (MM_MOBILE_EQUIPMENT_ERROR, >>>> MM_MOBILE_EQUIPMENT_ERROR_GPRS_CONGESTION, >>>> "Congestion"); >>>> + case MBIM_NW_ERROR_MISSING_OR_UNKNOWN_APN: >>>> + return g_error_new (MM_MOBILE_EQUIPMENT_ERROR, >>>> + >>>> MM_MOBILE_EQUIPMENT_ERROR_GPRS_MISSING_OR_UNKNOWN_APN, >>>> + "Missing or unknown APN"); >>>> + case MBIM_NW_ERROR_REQUESTED_SERVICE_OPTION_NOT_SUBSCRIBED: >>>> + return g_error_new (MM_MOBILE_EQUIPMENT_ERROR, >>>> + >>>> MM_MOBILE_EQUIPMENT_ERROR_GPRS_SERVICE_OPTION_NOT_SUBSCRIBED, >>>> + "Requested service option not >> subscribed"); >>>> + >>>> default: >>>> return g_error_new (MM_MOBILE_EQUIPMENT_ERROR, >>>> MM_MOBILE_EQUIPMENT_ERROR_GPRS_UNKNOWN, >>>> -- >>>> 2.0.0.526.g5318336 >>>> >>>> >>> _______________________________________________ >>> ModemManager-devel mailing list >>> <a href="mailto:ModemManager-devel@lists.freedesktop.org">ModemManager-devel@lists.freedesktop.org</a> >>> <a href="http://lists.freedesktop.org/mailman/listinfo/modemmanager-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/modemmanager-devel</a> >> >> >> > > > > _______________________________________________ > ModemManager-devel mailing list > <a href="mailto:ModemManager-devel@lists.freedesktop.org">ModemManager-devel@lists.freedesktop.org</a> > <a href="http://lists.freedesktop.org/mailman/listinfo/modemmanager-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/modemmanager-devel</a> > </div></div>-- Aleksander <a href="https://aleksander.es" target="_blank">https://aleksander.es</a> <div class="HOEnZb"><div class="h5">_______________________________________________ ModemManager-devel mailing list <a href="mailto:ModemManager-devel@lists.freedesktop.org">ModemManager-devel@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/modemmanager-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/modemmanager-devel</a> </div></div></blockquote></div> </div>