That makes sense, then you can do something akin to Fullscreen = !Fullscreen to toggle<div>Here's the current patch, but i'm not sure what i should do when you said "We also can't really say that the media player should implement these additions, since we want to be backwards compatible" </div> <div><br><div class="gmail_quote">On Mon, Jan 16, 2012 at 5:30 AM, Alex Merry <span dir="ltr"><<a href="mailto:kde@randomguy3.me.uk">kde@randomguy3.me.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div text="#000000" bgcolor="#FFFFFF"> Nope, mailing list is fine. I'll add a HACKING file to the tree.<br> <br> I'm not sure whether the root interface is the right place for this, or whether it should be in Player. I guess it fits with Raise, though.<br> <br> I think Fullscreen should be a property - unlike Raise or Quit, it is a state (either you are fullscreen or you are not) and so requesting the value makes sense. Also, Fullscreen is a noun, not a verb.<br> <br> I also think (for the same reasons) that CanFullscreen should be CanSetFullscreen. We also can't really say that the media player should implement these additions, since we want to be backwards compatible. So clients will need to cope gracefully with the relevant properties/methods not existing.<br> <br> Alex<br> <br> <br> On 16/01/12 00:24, Kevin Anthony wrote: <blockquote type="cite">I couldn't find a hacking file, so i'm unsure where to submit the patch. So i figured i'd submit it to the mailing list. If i'm supposed to submit it somewhere else, please let me know and i'll submit it there. <div> <br> </div> <div>Thanks</div> <div>Kevin Anthony<br> <br> <div class="gmail_quote">On Sun, Jan 15, 2012 at 5:07 PM, Alex Merry <span dir="ltr"><<a href="mailto:kde@randomguy3.me.uk" target="_blank">kde@randomguy3.me.uk</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 14/01/12 18:41, Kevin Anthony wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> I would like to propose adding two methods, or one method with a boolean flag, that allows, if a video was playing, to fullscreen/un-fullscreen the players.<br> <br> Although i have nothing to back this up, i think most people watch there movies in fullscreen most of the time. And i feel any remote would be incomplete without being able to fullscreen the players.<br> </blockquote> <br> Hmm... that's not a bad idea. Where I can see it being most useful is for LIRC-style controllers that use MPRIS (or bluetooth-based phone remotes etc).<br> <br> My suggestion would be two Player properties:<br> FullScreen: boolean, read/write<br> CanSetFullScreen: boolean, read-only<br> the second determining whether the first can be written to.<br> <br> Alex<br> _______________________________________________<br> MPRIS mailing list<br> <a href="mailto:MPRIS@lists.freedesktop.org" target="_blank">MPRIS@lists.freedesktop.org</a><br> <a href="http://lists.freedesktop.org/mailman/listinfo/mpris" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mpris</a><br> </blockquote> </div> <br> <br clear="all"> <div><br> </div> -- <br> Thanks<br> Kevin Anthony<br> <a href="http://www.NoSideRacing.com" target="_blank">www.NoSideRacing.com</a> <div><br> <div>Do you use Banshee?</div> </div> <div>Download the Community Extensions:</div> <div><a href="http://banshee.fm/download/extensions/" target="_blank">http://banshee.fm/download/extensions/</a></div> <br> </div> <br> <fieldset></fieldset> <br> <pre>_______________________________________________ MPRIS mailing list <a href="mailto:MPRIS@lists.freedesktop.org" target="_blank">MPRIS@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/mpris" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mpris</a> </pre> </blockquote> <br> </div> <br>_______________________________________________<br> MPRIS mailing list<br> <a href="mailto:MPRIS@lists.freedesktop.org">MPRIS@lists.freedesktop.org</a><br> <a href="http://lists.freedesktop.org/mailman/listinfo/mpris" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mpris</a><br> <br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Thanks<br>Kevin Anthony<br><a href="http://www.NoSideRacing.com" target="_blank">www.NoSideRacing.com</a><div><br><div>Do you use Banshee?</div></div><div> Download the Community Extensions:</div><div><a href="http://banshee.fm/download/extensions/" target="_blank">http://banshee.fm/download/extensions/</a></div><br> </div>