Glad that I could contribute a bit :)<div> </div><div>For some reason, I'm not being able to clone from <a href="http://cgit.collabora.com/git/user/kakaroto/libnice.git" target="_blank" style>http://cgit.collabora.com/git/user/kakaroto/libnice.git</a>, but only from git://<a href="http://git.collabora.co.uk/git/libnice.git">git.collabora.co.uk/git/libnice.git</a>, where the last commit was in September... <div class="gmail_quote">On Fri, Jan 13, 2012 at 12:29 AM, Youness Alaoui <<a href="mailto:youness.alaoui@collabora.co.uk">youness.alaoui@collabora.co.uk</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Ok it's fixed. thanks for reporting/noticing it! The patches are in my git repository available here : <a href="http://cgit.collabora.com/git/user/kakaroto/libnice.git/" target="_blank">http://cgit.collabora.com/git/user/kakaroto/libnice.git/</a> And here is the diff of the two patches that I needed to fix the bug : <a href="http://cgit.collabora.com/git/user/kakaroto/libnice.git/commit/?id=32b1b90f7aef5595829c6443f0a63ab0e492c9a3" target="_blank">http://cgit.collabora.com/git/user/kakaroto/libnice.git/commit/?id=32b1b90f7aef5595829c6443f0a63ab0e492c9a3</a> <a href="http://cgit.collabora.com/git/user/kakaroto/libnice.git/commit/?id=db2e674f516e8695adb3d302610bf6a15e5c0d70" target="_blank">http://cgit.collabora.com/git/user/kakaroto/libnice.git/commit/?id=db2e674f516e8695adb3d302610bf6a15e5c0d70</a> Youness. <div class="HOEnZb"><div class="h5"> On 01/12/2012 04:14 PM, Youness Alaoui wrote: > oh wow, first bug in a while! You're right, that's not normal and I just found > the bug, it was a stupid logic error. I was only cancelling the upnp_timeout > timer if there were still some pending upnp requests (was checking for the > length of the list, and forgot to do == 0). > I've fixed it now but i broke some unit tests, so I'm looking into what side > effects that caused. > > On 01/12/2012 06:08 AM, Eduardo Bezerra wrote: >> I have a router with upnp support, but I got the following output when trying >> some code that uses libnice. It seems to successfully create a port forwarding >> rule with upnp, but then it says "timeout". Is this a problem? I attached the >> code so that you can see it if you want (I borrowed it from a previous poster to >> the list). >> >> (...) >> (process:14384): libnice-DEBUG: Agent 0x1fbadf0: Adding UPnP port >> <a href="http://192.168.1.117:54321" target="_blank">192.168.1.117:54321</a> <<a href="http://192.168.1.117:54321" target="_blank">http://192.168.1.117:54321</a>> >> (process:14384): libnice-DEBUG: Agent 0x1fbadf0 : Adding new srv-rflx candidate >> discovery 0x7fdfbfa35010 >> >> (process:14384): libnice-DEBUG: Agent 0x1fbadf0 : discovery tick #1 with list >> 0x1faef40 (1) >> (process:14384): libnice-DEBUG: Agent 0x1fbadf0 : discovery - scheduling cand >> type 1 addr 127.0.0.1. >> >> (process:14384): libnice-DEBUG: Agent 0x1fbadf0 : stream 1 component 1 >> STATE-CHANGE 0 -> 1. >> cb_component_state_changed >> >> (process:14384): GLib-GIO-WARNING **: g_simple_async_result_complete() called >> from wrong context! >> >> (process:14384): GLib-GIO-WARNING **: g_simple_async_result_complete() called >> from wrong context! >> >> (process:14384): GLib-GIO-WARNING **: g_simple_async_result_complete() called >> from wrong context! >> (process:14384): libnice-DEBUG: Agent 0x1fbadf0 : Successfully mapped >> <a href="http://192.168.1.117:54321" target="_blank">192.168.1.117:54321</a> <<a href="http://192.168.1.117:54321" target="_blank">http://192.168.1.117:54321</a>> to <a href="http://95.127.127.155:54321" target="_blank">95.127.127.155:54321</a> >> <<a href="http://95.127.127.155:54321" target="_blank">http://95.127.127.155:54321</a>> >> (process:14384): libnice-DEBUG: Agent 0x1fbadf0 : UPnP port mapping timed out >> (...) >> >> Eduardo >> >> >> _______________________________________________ >> Nice mailing list >> <a href="mailto:Nice@lists.freedesktop.org">Nice@lists.freedesktop.org</a> >> <a href="http://lists.freedesktop.org/mailman/listinfo/nice" target="_blank">http://lists.freedesktop.org/mailman/listinfo/nice</a> > > > > > _______________________________________________ > Nice mailing list > <a href="mailto:Nice@lists.freedesktop.org">Nice@lists.freedesktop.org</a> > <a href="http://lists.freedesktop.org/mailman/listinfo/nice" target="_blank">http://lists.freedesktop.org/mailman/listinfo/nice</a> </div></div> _______________________________________________ Nice mailing list <a href="mailto:Nice@lists.freedesktop.org">Nice@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/nice" target="_blank">http://lists.freedesktop.org/mailman/listinfo/nice</a> </blockquote></div> </div>