<div dir="ltr"><div>When using RFC5245, then the username/password is set with nice_agent_set_remote_credentials, and all the candidates use the same user/pass. What you changed is a function to find which remote candidate the peer used by using the username/password to detect it because for google and MSN compatibilities, they use a different username/password per candidate. </div><div>So I would say your patch is wrong. There were some changes to how local/remote candidates are detected in the latest git master, maybe you can try that and explain what your issue is if it persists.</div><div> </div><div>Thanks,</div><div>Youness.</div><div> </div></div><div class="gmail_extra"> <div class="gmail_quote">On Mon, Jan 20, 2014 at 3:21 AM, Yannick LE COENT <<a href="mailto:yannick.lecoent@nexcom.fr" target="_blank">yannick.lecoent@nexcom.fr</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="FR" link="blue" vlink="purple"><div>Hi, I use libnice-0.1.4 with licode MCU and ICE connectivity check does not seem to work with peer reflexive candidates.The MCU uses the NICE_COMPATIBILITY_RFC5245 mode. The debug indicates that the peer reflexive is checked with an empty username and password (not the ones from the remote candidate). I added the following in conncheck.c (line # 2826) and now it works. agent->compatibility == NICE_COMPATIBILITY_RFC5245 || Is it the right patch ? Thanks for any help,Yannick </div></div> _______________________________________________ nice mailing list <a href="mailto:nice@lists.freedesktop.org">nice@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/nice" target="_blank">http://lists.freedesktop.org/mailman/listinfo/nice</a> </blockquote></div> </div>