[Nouveau] [PATCH 4/4] drm/nouveau: change FB map to simple ioremap
pq at iki.fi
Sun Jul 26 04:58:45 PDT 2009
On Sun, 26 Jul 2009 21:08:09 +1000
Dave Airlie <airlied at gmail.com> wrote:
> On Sun, Jul 26, 2009 at 9:03 PM, Dave Airlie<airlied at gmail.com> wrote:
> > On Sat, Jul 25, 2009 at 10:29 PM, Pekka Paalanen<pq at iki.fi> wrote:
> >> Remove the use of drm_local_map for the FB mapping and replace it with
> >> the equivalent ioremap.
> > I don't think FBs are ioremapped normally with addmap, unless nouveau
> > does something different here. Generally ioremapping the whole framebuffer
> > is considered a bad idea as ioremap on 32-bit x86 is limited.
> /me reads patch properly ;-)
> Notice DRM_REGISTERS. oops. looks fine then.
Yeah, the name '->fb' could be better, but at least there's a comment in
the code that it's not really the whole FB :-P
Thanks for the review.
More information about the Nouveau