[Nouveau] [Mesa3d-dev] [PATCH 2/2] st: don't assert on empty fragment program

Brian Paul brianp at vmware.com
Mon Jan 18 10:01:44 PST 2010


Luca Barbieri wrote:
> Sauerbraten triggers this assert.
> ---
>  src/mesa/state_tracker/st_atom_shader.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/src/mesa/state_tracker/st_atom_shader.c b/src/mesa/state_tracker/st_atom_shader.c
> index 176f3ea..fce533a 100644
> --- a/src/mesa/state_tracker/st_atom_shader.c
> +++ b/src/mesa/state_tracker/st_atom_shader.c
> @@ -79,8 +79,6 @@ translate_fp(struct st_context *st,
>  
>        stfp->num_input_slots = numIn;
>  
> -      assert(stfp->Base.Base.NumInstructions > 1);
> -
>        st_translate_fragment_program(st, stfp, stfp->input_to_slot);
>     }
>  }

How do we end up with a shader that has only one instruction (or 
none)?  Is it an END instruction?  I'd like to learn more about what's 
happening before committing this.

-Brian



More information about the Nouveau mailing list