[Nouveau] [PATCH] drm/nouveau: Add module options to disable acceleration.

[Pekka Paalanen]

On Tue, 26 Jan 2010 14:00:42 +0000
Marcin Kościelnicki <koriakin at 0x04.net> wrote:

> noaccel=1 disables all acceleration and doesn't even attempt
> initialising PGRAPH+PFIFO, nofbaccel=1 only makes fbcon
> unaccelerated.
> 
> Signed-off-by: Marcin Kościelnicki <koriakin at 0x04.net>
> ---
>  drivers/gpu/drm/nouveau/nouveau_drv.c   |    8 +++++++
>  drivers/gpu/drm/nouveau/nouveau_drv.h   |    2 +
>  drivers/gpu/drm/nouveau/nouveau_fbcon.c |   10 ++++++--
>  drivers/gpu/drm/nouveau/nouveau_state.c |   32
> +++++++++++++++++++----------- 4 files changed, 37 insertions(+),
> 15 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.c
> b/drivers/gpu/drm/nouveau/nouveau_drv.c index 343ab7f..a44c3f9
> 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drv.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_drv.c
> @@ -75,6 +75,14 @@ MODULE_PARM_DESC(ignorelid, "Ignore ACPI lid status");
> int nouveau_ignorelid = 0;
>  module_param_named(ignorelid, nouveau_ignorelid, int, 0400);
>  
> +MODULE_PARM_DESC(noagp, "Disable all acceleration");
> +int nouveau_noaccel = 0;
> +module_param_named(noaccel, nouveau_noaccel, int, 0400);
> +
> +MODULE_PARM_DESC(noagp, "Disable fbcon acceleration");
> +int nouveau_nofbaccel = 0;

Globals should not be initialized to zero, since they default to
zero. checkpatch.pl complains:
ERROR: do not initialise externals to 0 or NULL

-- 
Pekka Paalanen
http://www.iki.fi/pq/